Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant mock backport dependency and upgrade syntax for Python 3.8+ #785

Merged
merged 6 commits into from
Jul 20, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jul 20, 2024

Description

Describe what this change achieves.

Remove the redundant mock backport dependency and use the standard library version. Upgrade Python syntax for Python 3.8+.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dblock dblock merged commit 6e3f1a1 into opensearch-project:main Jul 20, 2024
67 checks passed
@hugovk hugovk deleted the pyupgrade branch July 20, 2024 21:19
dblock pushed a commit to dblock/opensearch-py that referenced this pull request Aug 15, 2024
…on 3.8+ (opensearch-project#785)

* Upgrade syntax with pyupgrade --py38-plus

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

* Convert to f-strings with flynt

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

* Format with Black

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

* Remove redundant mock backport dependency

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

* isort imports

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

* Add changelog entry

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

---------

Signed-off-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants