fix: retry_on_conflicts is not bool #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
dblock
force-pushed
the
pattrickrice-fix-retry-typing
branch
from
a1b3cfe
to
bb05213
Compare
dblock
force-pushed
the
pattrickrice-fix-retry-typing
branch
from
bb05213
to
3e41f5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
- Coverage 71.95% 70.25% -1.71%
==========================================
Files 91 113 +22
Lines 8001 8881 +880
==========================================
+ Hits 5757 6239 +482
- Misses 2244 2642 +398 ☔ View full report in Codecov by Sentry. |
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
pattrickrice-fix-retry-typing
branch
from
3e41f5b
to
00e36a1
Compare
saimedhi
approved these changes
Aug 15, 2024
dblock
added a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
Signed-off-by: dblock <dblock@amazon.com> Co-authored-by: Patrick Rice <patrickrice20@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verified that retry_on_conflict is an integer here.
Finishes #690.
Issues Resolved
Closes #690.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.