Fixed timeout argument in Transport

[borisevich-a-v]

Description

Fixed bug #809

Issues Resolved

• Timeout argument in Transport.perform_request is not used, because it is redefined just below

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[borisevich-a-v]

Sorry, I cannot satisfy DCO due to my account settings. But PR is signed off correctly

[dblock]

Add a test please?

I am not sure what the issue with DCO is, why can’t it be fixed with your account?

[borisevich-a-v]

Add a test please?

Sure, I'll add

I am not sure what the issue with DCO is, why can’t it be fixed with your account?

Hope it will not be a problem. I have two GitHub accounts due to job requirements. And for this one I have secondary email address for a while.

[borisevich-a-v]

Added test and also fixed the same problem with ignore, if you don't mind

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (ba715b9) to head (0e5bf2e).
Report is 58 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   71.95%   70.31%   -1.64%     
==========================================
  Files          91      113      +22     
  Lines        8001     8866     +865     
==========================================
+ Hits         5757     6234     +477     
- Misses       2244     2632     +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[borisevich-a-v]

@dblock
Added tests, fixed AsyncTransport as well
Tried to add code in the same code style, if there is any mistakes let me know

[dblock]

I am not sure what the issue with DCO is, why can’t it be fixed with your account?

Hope it will not be a problem. I have two GitHub accounts due to job requirements. And for this one I have secondary email address for a while.

I am not supposed to approve PRs without passing DCO :) Let's try to fix it.

You can configure the email address per repo. I do this routinely on a work computer for anything non-work.

git config user.name ...
git config user.email ...

Does this work?

[borisevich-a-v]

Does this work?

The problem was with my emails. I have satisfied DCO :)

[dblock]

Thanks for fixing this!