Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: generator adds new namespace. #813

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 26, 2024

Description

Fixes nox -rs generate by properly adding any new namespace in-place of other ones.

Screenshot 2024-08-26 at 3 24 21 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (ba715b9) to head (218bc15).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   71.95%   70.35%   -1.61%     
==========================================
  Files          91      113      +22     
  Lines        8001     8877     +876     
==========================================
+ Hits         5757     6245     +488     
- Misses       2244     2632     +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saimedhi saimedhi merged commit a24b9f3 into opensearch-project:main Aug 28, 2024
41 of 42 checks passed
@dblock dblock deleted the fix-generator-new-namespace branch August 28, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants