-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add OpenSearch configuration for SDKClient to read to #206
Comments
When we start up an extension, it listens on its configured port and when it receives the "init" transport request from OpenSearch it then has access to an OpenSearchNode object with this data. I don't have a strong argument against defining these here, but it duplicates configs and I'd really like to understand the reasoning for it. For example, is it intended to support a use case where we start an extension after OpenSearch is already started up, and thus doesn't send the init request? |
I created this for the use case like. To invoke the method getOpenSearchNode we have to make it static and set the Node before that. I am trying to avoid it and add the hostAddress and port in the yml file. This will also help us if one extension wants to talk to another then we can change the hostAddress and port. Let me know WDYT. |
Thanks for the example. I thin the problem is real but this is not the right solution. This is actually a much wider issue with anything else we need from OpenSearch like knowing if dependencies are initialized (#149), getting OS settings (#157), and obtaining information from dependent extensions (settings, namedXContent, etc.) that has been registered first. The problem we have is our initialization sequence:
With
I think we may need to take the same approach with I think we should discuss the whole initialization sequence in #94, and update DESIGN.md to reflect what's decided there. |
Alternately, at least from a host/port standpoint, this may be needed for the "add an extension to an already running OpenSearch" use case, which should also be discussed in #94. |
Based on a primary (future) use case of enabling extensions to connect to an already-running OpenSearch cluster until #94 is done. |
Is your feature request related to a problem?
Currently the extensions.yml file doesn't have configuration of OpenSearch such as address and port to connect to. After integrating SDKClient with an extension it requires the above mentioned attributed to connect to.
What solution would you like?
Add address and port getters in ExtensionSettings
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: