-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions] Create Detector Workflow #692
[Feature/extensions] Create Detector Workflow #692
Conversation
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
src/main/java/org/opensearch/ad/rest/RestCreateDetectorAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestCreateDetectorAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Codecov Report
@@ Coverage Diff @@
## feature/extensions #692 +/- ##
========================================================
- Coverage 53.81% 53.37% -0.44%
Complexity 2679 2679
========================================================
Files 288 290 +2
Lines 16004 16134 +130
Branches 1703 1706 +3
========================================================
Hits 8612 8612
- Misses 6767 6897 +130
Partials 625 625
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job! A few comments (can be resolved to merge).
Description
This is an initial draft PR for create detector workflow.Not able to start AD Extension because while creating the handler I'm passing null for settings and clusterService
handler = List.of(new RestCreateDetectorAction(null, null));
as these objects will be available through createComponentThis PR adds:
Issues Resolved
opensearch-project/opensearch-sdk-java#58
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.