Create Component Integration #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DTaskManager Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
joshpalis
reviewed
Oct 14, 2022
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
|
@ryanbogan looks like the PR is in draft, is it ready and looks like there are few conflicts . |
I'll fix the conflicts, but I wanted to make sure the conceptual design and constructor changes are correct |
dbwiddis
reviewed
Oct 14, 2022
| /** | ||
| * Constructor function | ||
| * | ||
| * @param client ES client supports administrative actions |
There was a problem hiding this comment.
let's change ES to OS if we're copying docs :)
| this.clusterService = clusterService; | ||
| this.threadPool = threadPool; | ||
|
|
||
| //TODO: Ask Dan what this is |
There was a problem hiding this comment.
Is this a TODO to ask me or is this asking me? (I actually don't know.)
There was a problem hiding this comment.
Oh yeah I put that in there for me to ask if it was necessary or if I could delete it
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
joshpalis
reviewed
Oct 17, 2022
src/main/java/org/opensearch/ad/indices/AnomalyDetectionIndices.java
Outdated
Show resolved
Hide resolved
joshpalis
reviewed
Oct 17, 2022
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
…g, BatchWorker, CheckpointWriteWorker, ConcurrentWorker, ReateLimitedRequestWork. Fixed consumers for SearchFeatureDao, ADTaskManager. Updated build.gradle to include opensearch-java OpenSearchClient. Only remaining errors now involve the OpenSearchClient Signed-off-by: Joshua Palis <jpalis@amazon.com>
…es. Adding cluster state support to AnomalyDetectionIndices, adding addSettingsUpdateConsumers support to MemoryTracker Signed-off-by: Joshua Palis <jpalis@amazon.com>
…alyDetectionIndices Signed-off-by: Ryan Bogan <rbogan@amazon.com>
…ices.java Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Component Integration
Signed-off-by: Ryan Bogan rbogan@amazon.com
Description
Integrates createComponents
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.