Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spotless check before gradle check #198

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Oct 17, 2022

Signed-off-by: Owais Kazi owaiskazi19@gmail.com

Description

Runs gradle check only if spotless is successful.

Issues Resolved

Part of #110

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 requested a review from a team October 17, 2022 21:29
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a different version of actions/checkout in the two workflows

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 changed the title Added spotless check before gradle check Run spotless check before gradle check Oct 17, 2022
@joshpalis joshpalis self-requested a review October 17, 2022 21:56
@dbwiddis dbwiddis merged commit ad33614 into opensearch-project:main Oct 17, 2022
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
* Added spotless check before gradle check

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Fix syntax

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Fixed action versions

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants