Migrate client transports to Apache HttpClient/Core5.x #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
commented
Nov 3, 2022
src/main/java/org/opensearch/sdk/handlers/EnvironmentSettingsResponseHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
============================================
+ Coverage 65.86% 66.86% +0.99%
+ Complexity 103 100 -3
============================================
Files 25 24 -1
Lines 501 501
Branches 17 17
============================================
+ Hits 330 335 +5
+ Misses 159 154 -5
Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshpalis
previously approved these changes
Nov 3, 2022
ryanbogan
previously approved these changes
Nov 3, 2022
dbwiddis
previously approved these changes
Nov 4, 2022
src/main/java/org/opensearch/sdk/handlers/ClusterStateResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/EnvironmentSettingsResponseHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
dismissed stale reviews from dbwiddis, ryanbogan, and joshpalis
via
5309b2c
ryanbogan
approved these changes
Nov 4, 2022
joshpalis
approved these changes
Nov 4, 2022
dbwiddis
approved these changes
Nov 4, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…oject#231) * Migrate client transports to Apache HttpClient/Core5.x Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Removed scheme Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Cleanep up compiler warnings Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated comment Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Generalized version numbers to a variable Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owais Kazi owaiskazi19@gmail.com
Description
This PR covers:
Issues Resolved
Closes #210 and #89
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.