Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed lucene dependency #465

Merged

Conversation

owaiskazi19
Copy link
Member

Description

Coming from #388. As SDK does not have dependency on lucene, removing it will be of less work for the mend bot :)

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for now. We may have to add it back depending on what we do with AnalysisPlugin extension points.... would be nice if OpenSearch has a version catalog tho.

@owaiskazi19 owaiskazi19 merged commit 4be7546 into opensearch-project:main Feb 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
(cherry picked from commit 4be7546)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Feb 20, 2023
(cherry picked from commit 4be7546)

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants