Implement getFieldMapping on SDKRestClient #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #672 +/- ##
============================================
+ Coverage 63.86% 63.90% +0.03%
Complexity 274 274
============================================
Files 55 55
Lines 1168 1169 +1
Branches 38 38
============================================
+ Hits 746 747 +1
Misses 409 409
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
owaiskazi19
previously approved these changes
Apr 12, 2023
joshpalis
previously approved these changes
Apr 12, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
approved these changes
Apr 13, 2023
|
I was about to comment that |
joshpalis
approved these changes
Apr 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Implement getFieldMapping on SDKRestClient Signed-off-by: Daniel Widdis <widdis@gmail.com> * More migration notes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update to match variable options parameter. Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 51c321c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Implement getFieldMapping on SDKRestClient * More migration notes * Update to match variable options parameter. --------- (cherry picked from commit 51c321c) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the IndicesClient
getFieldMapping()method on the SDKRestClient.This provides identical functionality to the Transport Call on AD extension (
GetFieldMappingsAction.INSTANCE) used for validating the time field, enabling its migration without exposing OpenSearch TransportActions to extensions.Issues Resolved
Fixes #361
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.