Remove usage of important from breadcrumbs #624
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhishekReddy1127
force-pushed
the
OUI-Breadcrumb-avoid-important
branch
5 times, most recently
from
023a777 to
a6fd9c4
Compare
BSFishy
reviewed
Mar 28, 2023
src/components/link/link.tsx
Outdated
There was a problem hiding this comment.
Adding a color to links should preferably be done in another PR
| @@ -43,16 +40,11 @@ | |||
| .ouiBreadcrumb--collapsed { | |||
| flex-shrink: 0; | |||
| color: $ouiBreadcrumbCollapsedLink; | |||
| vertical-align: top !important; // sass-lint:disable-line no-important | |||
There was a problem hiding this comment.
Does removing this change the layout at all?
There was a problem hiding this comment.
@BSFishy Not any significant change i see.
AbhishekReddy1127
force-pushed
the
OUI-Breadcrumb-avoid-important
branch
from
a6fd9c4 to
49fbba3
Compare
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
AbhishekReddy1127
force-pushed
the
OUI-Breadcrumb-avoid-important
branch
from
49fbba3 to
f4fb366
Compare
|
@AbhishekReddy1127 @BSFishy want to finish this? Close unmerged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the usage of important for the breadcrumbs and ensured that it works as before.
Issues Resolved
Fixes #376
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.