Add props and examples for the combobox #660

AbhishekReddy1127 · 2023-04-04T20:33:48Z

Description

Added props and examples for the combo box.

Issues Resolved

Fixes #98

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BSFishy · 2023-04-08T00:07:49Z

.github/workflows/release-drafter.yml

Why is 4c5e17dc9ff66a401874a161a8f3ea3c65904a4d in this PR?

Can we rebase this PR to main?

bandinib-amzn · 2023-04-08T00:21:35Z

src-docs/src/views/combo_box/combo_box_custom_icon.js

+    },
+  ]);
+
+  const [selectedOptions, setSelected] = useState([options[2], options[4]]);


Why we choose option 2 and option 4? If they are default values, can we store them in constant and add comment so that in future if want to decide change the default values it will be easier for other developers?

These examples are just to demo icon prop usage, I think moving to common won't be the right thing because consumers when use the example will also need to be aware and refer to common code stored which would be else where.

bandinib-amzn · 2023-04-08T00:26:31Z

src-docs/src/views/combo_box/combo_box_default_icon.js

+
+    // Select the option.
+    setSelected((prevSelected) => [...prevSelected, newOption]);
+  };


Code from Line 16 to Line 80 is same in both combo_box_custome_icon.js and combo_box_default_icon.js. Is it possible to reuse the code?

These changes are just for demonstration purpose, examples on how to combo box with custom icon and and default search icon.
It not basically part of actual implementation. If we re-use then i think the example snippet will be disturbed...

I remember seeing some of these sample codes shared between examples. We could look at combining them after merging this PR.

Let's create an issue to refactor this code and avoid duplication and reuse examples. Approving this PR.

Thanks. Created: #830

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

opensearch-trigger-bot · 2023-06-20T05:11:11Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-660-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 af0883cb0b87fe93fb3f6c6bd5aaafc8014880c0
# Push it to GitHub
git push --set-upstream origin backport/backport-660-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-660-to-1.x.

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

* Remove beta badge accent color (#99) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: Matt Provost <provomat@amazon.com> * OUI combo box refine (#183) * Added a prop clearOnBlur Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Added example for prop clearOnBlur Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> --------- Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Update Comment List Docs (#252) Signed-off-by: Matt Provost <provomat@amazon.com> * Updated the section Collapsable Nav (#330) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Updated the kibana to opensearch_dashboards (#343) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the section drag and drop (#514) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Update @svgr/core and @svgr/plugin-svgo (#594) (#649) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Migrate from faker to @faker-js/faker (#594) (#655) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Bump @faker-js/faker to v8 (#594) (#768) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * change beta to experimental (#383) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Normalize interlink URL usage (#698) (#720) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * [CCI] Add `useDeprecatedPropWarning` and align with `deprecated` hoc (#762) * Add useDeprecatedPropWarning and align with deprecated hoc (#761) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> * Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (#761) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> * Use ExclusiveUnion in interfaces (#761) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> --------- Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * Update the default branch (#584) (#798) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * [OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806) Signed-off-by: Miki <miki@amazon.com> * Updated bug issue template (#764) * Update bug issue template Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * Add spacing Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * Move OuiBottomBar default inline styles to the CSS file (#693) (#694) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * [CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652) * Update react-window (#594) * Update react-virtualized-auto-sizer (#594) Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> --------- Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Update dropzone (#594) (#651) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Updated the section Beta badge (#338) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Add props and examples for the combobox (#660) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the links in the section Markdown Format (#365) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Update Notification event page (#549) Signed-off-by: manasvinibs <manasvis@amazon.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * Updated the content in the section Messages and loading (#350) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the content in the section suggest (#347) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Update affiliation of Andrey and Sergey (#794) Signed-off-by: Matt Provost <provomat@amazon.com> * [CCI] Update dependencies (#716) * Update dependencies (#594) Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1 Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * Bump react-window, tabbable and rimraf patch versions Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> * Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8 Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> --------- Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> * Replace @elastic/datemath with @opensearch/datemath (#204) * Replace @elastic/datemath with @opensearch/datemath Signed-off-by: Matt Provost <provomat@amazon.com> * Clean up Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> * Bump semver to 7.5.3 (#855) * Bump semver to 7.5.3 Signed-off-by: Matt Provost <provomat@amazon.com> * Add resolution to eslint plugin Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> * Remove Split button from OUI docs (#805) (#812) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> * Updated the text in the section ErrorBoundary (#366) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Docs site changes (#96) * first change Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * undoing first change Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * making a sample change to test commit success or failure Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * undoes sample change for testing Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * minor changes for tone, deleted references to starter projects as they are not maintained by OSD Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * Delete OUI.iml Removing as included accidentally. * Delete oui.iml Removing as included accidentally. * Update getting_started.md Updated link to node version manager to avoid redirect --------- Signed-off-by: Kroosh Crusius <kroosh@amazon.com> * Update getting_started.md to remove elastic reference and other changes (#502) Signed-off-by: manasvinibs <manasvis@amazon.com> * Removed GitHub column from all the tables (#371) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Updated the content and Icons in the section CssUtilityClasses (#368) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Delete Kibana reference in commands (#535) * Delete kibana reference in commands Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change the tgz naming to opensearch Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Updated doc site link and github reference Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change URL to only include domain Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> * fixed invalid link in FAQ.md (#751) Signed-off-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: manasvinibs <manasvis@amazon.com> Signed-off-by: Kroosh Crusius <kroosh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com> Co-authored-by: Matt Provost <provomat@amazon.com> Co-authored-by: Abhishek Reddy <62020972+AbhishekReddy1127@users.noreply.github.com> Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com> Co-authored-by: Andrey Myssak <40265277+andreymyssak@users.noreply.github.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com> Co-authored-by: Kroosh <kroosh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Aigerim Suleimenova <aigerim.suleimenova27@gmail.com>

AbhishekReddy1127 marked this pull request as ready for review April 4, 2023 20:34

AbhishekReddy1127 requested a review from a team as a code owner April 4, 2023 20:34

BSFishy approved these changes Apr 4, 2023

View reviewed changes

AbhishekReddy1127 added the backport 1.x label Apr 5, 2023

BSFishy suggested changes Apr 8, 2023

View reviewed changes

AbhishekReddy1127 force-pushed the OUI-combo-box branch from bd8e31d to 649180f Compare April 8, 2023 00:12

AbhishekReddy1127 requested review from seanneumann, AMoo-Miki, rednaksi91 and KrooshalUX as code owners April 8, 2023 00:12

AbhishekReddy1127 requested review from BSFishy and bandinib-amzn April 8, 2023 00:13

bandinib-amzn requested changes Apr 8, 2023

View reviewed changes

AbhishekReddy1127 force-pushed the OUI-combo-box branch from 649180f to 9620095 Compare April 12, 2023 22:15

Add props and examples for the combobox

e2fa460

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

AbhishekReddy1127 force-pushed the OUI-combo-box branch from 9620095 to e2fa460 Compare April 20, 2023 17:56

BSFishy approved these changes Apr 25, 2023

View reviewed changes

bandinib-amzn approved these changes Jun 20, 2023

View reviewed changes

AMoo-Miki mentioned this pull request Jun 20, 2023

Remove possible duplication from combo_box_*_icon.js files #830

Open

AMoo-Miki merged commit af0883c into opensearch-project:main Jun 20, 2023

AMoo-Miki pushed a commit to AMoo-Miki/oui that referenced this pull request Jul 2, 2023

Add props and examples for the combobox (opensearch-project#660)

7785a60

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>

AMoo-Miki mentioned this pull request Jul 2, 2023

[Manual][backport 1.x] Several changes #872

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add props and examples for the combobox #660

Add props and examples for the combobox #660

AbhishekReddy1127 commented Apr 4, 2023

BSFishy Apr 8, 2023

bandinib-amzn Apr 8, 2023

bandinib-amzn Apr 8, 2023 •

edited

Loading

AbhishekReddy1127 Apr 20, 2023

bandinib-amzn Apr 8, 2023

AbhishekReddy1127 Apr 12, 2023 •

edited

Loading

AMoo-Miki Jun 20, 2023

bandinib-amzn Jun 20, 2023

AMoo-Miki Jun 20, 2023

opensearch-trigger-bot bot commented Jun 20, 2023

Add props and examples for the combobox #660

Add props and examples for the combobox #660

Conversation

AbhishekReddy1127 commented Apr 4, 2023

Description

Issues Resolved

Check List

BSFishy Apr 8, 2023

Choose a reason for hiding this comment

bandinib-amzn Apr 8, 2023

Choose a reason for hiding this comment

bandinib-amzn Apr 8, 2023 • edited Loading

Choose a reason for hiding this comment

AbhishekReddy1127 Apr 20, 2023

Choose a reason for hiding this comment

bandinib-amzn Apr 8, 2023

Choose a reason for hiding this comment

AbhishekReddy1127 Apr 12, 2023 • edited Loading

Choose a reason for hiding this comment

AMoo-Miki Jun 20, 2023

Choose a reason for hiding this comment

bandinib-amzn Jun 20, 2023

Choose a reason for hiding this comment

AMoo-Miki Jun 20, 2023

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Jun 20, 2023

bandinib-amzn Apr 8, 2023 •

edited

Loading

AbhishekReddy1127 Apr 12, 2023 •

edited

Loading