-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI] Normalize interlink URL usage #720
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,8 @@ export default () => ( | |
<OuiSpacer size="xs" /> | ||
<OuiText size="s"> | ||
<p> | ||
Choice <OuiLink href="https://opensearch.org">Two</OuiLink> | ||
Choice{' '} | ||
<OuiLink href="https://oui.opensearch.org/latest/">Two</OuiLink> | ||
Comment on lines
+40
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
</p> | ||
</OuiText> | ||
</div> | ||
|
@@ -55,7 +56,8 @@ export default () => ( | |
<OuiSpacer size="xs" /> | ||
<OuiText size="s"> | ||
<p> | ||
Choice <OuiLink href="https://opensearch.org">Two</OuiLink> | ||
Choice{' '} | ||
<OuiLink href="https://oui.opensearch.org/latest/">Two</OuiLink> | ||
</p> | ||
</OuiText> | ||
</div> | ||
|
@@ -73,7 +75,8 @@ export default () => ( | |
<OuiSpacer size="xs" /> | ||
<OuiText size="s"> | ||
<p> | ||
Choice <OuiLink href="https://opensearch.org">Two</OuiLink> | ||
Choice{' '} | ||
<OuiLink href="https://oui.opensearch.org/latest/">Two</OuiLink> | ||
</p> | ||
</OuiText> | ||
</div> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,7 +57,7 @@ export default () => ( | |
<OuiFlexItem> | ||
<OuiCard | ||
textAlign="left" | ||
href="https://oui.opensearch.org/" | ||
href="https://oui.opensearch.org/latest/" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
image="https://source.unsplash.com/400x200/?City" | ||
icon={<OuiIcon size="xxl" type="logoBeats" />} | ||
title={'Title'} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ export default () => ( | |
title={'No icon example'} | ||
description="Example of a card's description. Stick to one or two sentences." | ||
onClick={() => {}} | ||
href="#" | ||
href="https://oui.opensearch.org/latest/" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
/> | ||
</OuiFlexItem> | ||
</OuiFlexGroup> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ for (let i = 1; i < 20; i++) { | |
), | ||
email: faker.helpers.fake('{{internet.email}}'), | ||
city: ( | ||
<OuiLink href="http://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do the links to google here come from Faker? I am not sure if I remember. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They don't come from Faker. According to the history of commits, this change was made a long time ago - b64d503 |
||
{faker.helpers.fake('{{location.city}}')} | ||
</OuiLink> | ||
), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,7 @@ for (let i = 1; i < 20; i++) { | |
), | ||
email: faker.helpers.fake('{{internet.email}}'), | ||
city: ( | ||
<OuiLink href="http://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.city}}')} | ||
</OuiLink> | ||
), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,14 +46,16 @@ for (let i = 1; i < 100; i++) { | |
}, | ||
email: { | ||
formatted: ( | ||
<OuiLink href="">{faker.helpers.fake('{{internet.email}}')}</OuiLink> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
{faker.helpers.fake('{{internet.email}}')} | ||
</OuiLink> | ||
Comment on lines
+49
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
), | ||
raw: email, | ||
}, | ||
location: ( | ||
<Fragment> | ||
{`${faker.helpers.fake('{{location.city}}')}, `} | ||
<OuiLink href="https://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.country}}')} | ||
</OuiLink> | ||
</Fragment> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,12 +50,14 @@ for (let i = 1; i < 100; i++) { | |
'{{person.lastName}}, {{person.firstName}} {{person.suffix}}' | ||
), | ||
email: ( | ||
<OuiLink href="">{faker.helpers.fake('{{internet.email}}')}</OuiLink> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
{faker.helpers.fake('{{internet.email}}')} | ||
</OuiLink> | ||
Comment on lines
+53
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
), | ||
location: ( | ||
<Fragment> | ||
{`${faker.helpers.fake('{{location.city}}')}, `} | ||
<OuiLink href="https://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.country}}')} | ||
</OuiLink> | ||
</Fragment> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,12 +49,14 @@ for (let i = 1; i < 100; i++) { | |
'{{person.lastName}}, {{person.firstName}} {{person.suffix}}' | ||
), | ||
email: ( | ||
<OuiLink href="">{faker.helpers.fake('{{internet.email}}')}</OuiLink> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
{faker.helpers.fake('{{internet.email}}')} | ||
</OuiLink> | ||
Comment on lines
+52
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
), | ||
location: ( | ||
<Fragment> | ||
{`${faker.helpers.fake('{{location.city}}')}, `} | ||
<OuiLink href="https://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.country}}')} | ||
</OuiLink> | ||
</Fragment> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,12 +49,14 @@ for (let i = 1; i < 100; i++) { | |
'{{person.lastName}}, {{person.firstName}} {{person.suffix}}' | ||
), | ||
email: ( | ||
<OuiLink href="">{faker.helpers.fake('{{internet.email}}')}</OuiLink> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
{faker.helpers.fake('{{internet.email}}')} | ||
</OuiLink> | ||
Comment on lines
+52
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
), | ||
location: ( | ||
<Fragment> | ||
{`${faker.helpers.fake('{{location.city}}')}, `} | ||
<OuiLink href="https://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.country}}')} | ||
</OuiLink> | ||
</Fragment> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,12 +49,14 @@ for (let i = 1; i < 100; i++) { | |
'{{person.lastName}}, {{person.firstName}} {{person.suffix}}' | ||
), | ||
email: ( | ||
<OuiLink href="">{faker.helpers.fake('{{internet.email}}')}</OuiLink> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
{faker.helpers.fake('{{internet.email}}')} | ||
</OuiLink> | ||
Comment on lines
+52
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
), | ||
location: ( | ||
<Fragment> | ||
{`${faker.helpers.fake('{{location.city}}')}, `} | ||
<OuiLink href="https://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.country}}')} | ||
</OuiLink> | ||
</Fragment> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,11 +84,13 @@ function RenderCellValue({ rowIndex, columnId }) { | |
const suffix = faker.helpers.fake('{{person.suffix}}'); | ||
data[rowIndex] = { | ||
name: `${name} ${suffix}`, | ||
email: <OuiLink href="">{email}</OuiLink>, | ||
email: ( | ||
<OuiLink href="https://oui.opensearch.org/latest/">{email}</OuiLink> | ||
), | ||
Comment on lines
+87
to
+89
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
location: ( | ||
<Fragment> | ||
{`${faker.helpers.fake('{{location.city}}')}, `} | ||
<OuiLink href="https://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.country}}')} | ||
</OuiLink> | ||
</Fragment> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,11 +82,13 @@ function RenderCellValue({ rowIndex, columnId }) { | |
const suffix = faker.helpers.fake('{{person.suffix}}'); | ||
data[rowIndex] = { | ||
name: `${name} ${suffix}`, | ||
email: <OuiLink href="">{email}</OuiLink>, | ||
email: ( | ||
<OuiLink href="https://oui.opensearch.org/latest/">{email}</OuiLink> | ||
), | ||
Comment on lines
+85
to
+87
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
location: ( | ||
<Fragment> | ||
{`${faker.helpers.fake('{{location.city}}')}, `} | ||
<OuiLink href="https://google.com"> | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{faker.helpers.fake('{{location.country}}')} | ||
</OuiLink> | ||
</Fragment> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,8 @@ export default () => { | |
<OuiCallOut iconType="help"> | ||
<p> | ||
Here’s some stuff that you need to know. This banner helps | ||
highlight important information. <OuiLink href="#">View docs</OuiLink> | ||
highlight important information.{' '} | ||
<OuiLink href="https://oui.opensearch.org/latest/">View docs</OuiLink> | ||
Comment on lines
+38
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
</p> | ||
</OuiCallOut> | ||
); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,7 @@ export default () => { | |
const renderLogo = () => ( | ||
<OuiHeaderLogo | ||
iconType="logoOpenSearch" | ||
href="#" | ||
href="https://oui.opensearch.org/latest/" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
onClick={(e) => e.preventDefault()} | ||
aria-label="Go to home page" | ||
/> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,7 +48,11 @@ const HeaderUpdates = () => { | |
{ | ||
title: 'Control access to features', | ||
text: 'Show or hide applications and features per space in Kibana.', | ||
action: <OuiLink href="">Learn about feature controls</OuiLink>, | ||
action: ( | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
Learn about feature controls | ||
</OuiLink> | ||
), | ||
Comment on lines
+51
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
date: '1 May 2019', | ||
badge: <OuiBadge>7.1</OuiBadge>, | ||
}, | ||
|
@@ -71,7 +75,11 @@ const HeaderUpdates = () => { | |
title: 'Enter dark mode', | ||
text: | ||
'Kibana now supports the easy-on-the-eyes theme across the entire UI.', | ||
action: <OuiLink href="">Go to Advanced Settings</OuiLink>, | ||
action: ( | ||
<OuiLink href="https://oui.opensearch.org/latest/"> | ||
Go to Advanced Settings | ||
</OuiLink> | ||
), | ||
Comment on lines
+78
to
+82
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
date: '10 April 2019', | ||
badge: <OuiBadge color="hollow">7.0</OuiBadge>, | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -283,7 +283,9 @@ export default ({ theme }) => { | |
sections={[ | ||
{ | ||
items: [ | ||
<OuiHeaderLogo iconType="logoOpenSearch" href=""> | ||
<OuiHeaderLogo | ||
iconType="logoOpenSearch" | ||
href="https://oui.opensearch.org/latest/"> | ||
Comment on lines
+286
to
+288
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
OpenSearch | ||
</OuiHeaderLogo>, | ||
deploymentMenu, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,16 +95,16 @@ const headerLinksSnippet = `<OuiHeader> | |
<OuiHeaderSectionItem border="right"> | ||
<OuiHeaderLogo | ||
iconType="iconName" | ||
href="" | ||
href="https://oui.opensearch.org/latest/" | ||
/> | ||
</OuiHeaderSectionItem> | ||
|
||
<OuiHeaderLinks> | ||
<OuiHeaderLink href="" isActive> | ||
<OuiHeaderLink href="https://oui.opensearch.org/latest/" isActive> | ||
<!-- First link --> | ||
</OuiHeaderLink> | ||
|
||
<OuiHeaderLink href=""> | ||
<OuiHeaderLink href="https://oui.opensearch.org/latest/"> | ||
Comment on lines
+98
to
+107
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<!-- Second link --> | ||
</OuiHeaderLink> | ||
</OuiHeaderLinks> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ export default () => { | |
const renderLogo = ( | ||
<OuiHeaderLogo | ||
iconType="logoOpenSearch" | ||
href="#" | ||
href="https://oui.opensearch.org/latest/" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
onClick={(e) => e.preventDefault()} | ||
aria-label="Navigate to home page" | ||
/> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,21 +19,23 @@ import { | |
|
||
export default () => ( | ||
<OuiKeyPadMenu> | ||
<OuiKeyPadMenuItem label="Dashboard" href="#"> | ||
<OuiKeyPadMenuItem | ||
label="Dashboard" | ||
href="https://oui.opensearch.org/latest/"> | ||
<OuiIcon type="dashboardApp" size="l" /> | ||
</OuiKeyPadMenuItem> | ||
|
||
<OuiKeyPadMenuItem | ||
label="Dashboard" | ||
href="#" | ||
href="https://oui.opensearch.org/latest/" | ||
betaBadgeLabel="Experimental" | ||
betaBadgeTooltipContent="This module is not GA. Please help us by reporting any bugs."> | ||
<OuiIcon type="dashboardApp" size="l" /> | ||
</OuiKeyPadMenuItem> | ||
|
||
<OuiKeyPadMenuItem | ||
label="Dashboard" | ||
href="#" | ||
href="https://oui.opensearch.org/latest/" | ||
Comment on lines
+22
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
betaBadgeLabel="External" | ||
betaBadgeTooltipContent="This module is an external app." | ||
betaBadgeIconType="popout"> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,19 +19,28 @@ import { | |
|
||
export default () => ( | ||
<OuiKeyPadMenu> | ||
<OuiKeyPadMenuItem label="Dashboard" href="#"> | ||
<OuiKeyPadMenuItem | ||
label="Dashboard" | ||
href="https://oui.opensearch.org/latest/"> | ||
<OuiIcon type="dashboardApp" size="l" /> | ||
</OuiKeyPadMenuItem> | ||
|
||
<OuiKeyPadMenuItem label="Dashboard" href="#"> | ||
<OuiKeyPadMenuItem | ||
label="Dashboard" | ||
href="https://oui.opensearch.org/latest/"> | ||
<OuiIcon type="dashboardApp" size="l" /> | ||
</OuiKeyPadMenuItem> | ||
|
||
<OuiKeyPadMenuItem label="Dashboard" href="#"> | ||
<OuiKeyPadMenuItem | ||
label="Dashboard" | ||
href="https://oui.opensearch.org/latest/"> | ||
<OuiIcon type="dashboardApp" size="l" /> | ||
</OuiKeyPadMenuItem> | ||
|
||
<OuiKeyPadMenuItem isDisabled label="Dashboard" href="#"> | ||
<OuiKeyPadMenuItem | ||
isDisabled | ||
label="Dashboard" | ||
href="https://oui.opensearch.org/latest/"> | ||
<OuiIcon type="dashboardApp" size="l" /> | ||
</OuiKeyPadMenuItem> | ||
Comment on lines
+22
to
45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
</OuiKeyPadMenu> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,10 +27,10 @@ import KeyPadMenu from './key_pad_menu'; | |
const keyPadMenuSource = require('!!raw-loader!./key_pad_menu'); | ||
const keyPadMenuHtml = renderToHtml(KeyPadMenu); | ||
const keyPadMenuSnippet = `<OuiKeyPadMenu> | ||
<OuiKeyPadMenuItem label={label1} href="#"> | ||
<OuiKeyPadMenuItem label={label1} href="https://oui.opensearch.org/latest/"> | ||
<OuiIcon type={icon1} size="l" /> | ||
</OuiKeyPadMenuItem> | ||
<OuiKeyPadMenuItem label={label2} href="#"> | ||
<OuiKeyPadMenuItem label={label2} href="https://oui.opensearch.org/latest/"> | ||
Comment on lines
+30
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<OuiIcon type={icon2} size="l" /> | ||
</OuiKeyPadMenuItem> | ||
</OuiKeyPadMenu> | ||
|
@@ -51,7 +51,7 @@ const keyPadBetaSource = require('!!raw-loader!./key_pad_beta'); | |
const keyPadBetaHtml = renderToHtml(KeyPadBeta); | ||
const keyPadBetaSnippet = `<OuiKeyPadMenuItem | ||
label={label} | ||
href="#" | ||
href="https://oui.opensearch.org/latest/" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
betaBadgeLabel={betaBadgeLabel} | ||
betaBadgeTooltipContent={tooltipContent} | ||
betaBadgeIconType={badgeIconType}> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.