Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @andreymyssak and @SergeyMyssak as co-maintainers #789

Merged
merged 1 commit into from
May 26, 2023

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented May 26, 2023

Description

Following the process in opensearch-project/.github/RESPONSIBILITIES.md, I had nominated Andrey and Sergey Myssak (@andreymyssak and @SergeyMyssak) as co-maintainers. The maintainers have voted and agreed to this nomination.


I would like to nominate Sergey (SergeyMyssak on Github) and Andrey (andreymyssak on Github) as maintainers for OUI. They have made numerous contributions to OUI, including but not limited to helping fix issues in backports (#757), auditing usage of outdated dependencies and creating action items to remedy (#594 (comment)), and establishing a deprecation precedent for components (#606).

I see that opensearch-js has already accepted a CCI contributor as a maintainer so I don’t see any reason why we too shouldn’t 😊 . +1 to both since of the 22 merged CCI PR’s, they have contributed 19 of those PR.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>
Comment on lines +17 to +18
| Andrey Myssak | [andreymyssak](https://github.com/andreymyssak) | |
| Sergey Myssak | [SergeyMyssak](https://github.com/SergeyMyssak) | |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreymyssak @SergeyMyssak Do you want anything for affiliation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BSFishy I think we can leave it blank for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwin-pc ashwin-pc merged commit 46da469 into opensearch-project:main May 26, 2023
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-789-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 46da4697edb1865ccd6f58fcf9fe67c592e3be85
# Push it to GitHub
git push --set-upstream origin backport/backport-789-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-789-to-1.x.

@opensearch-trigger-bot
Copy link

The backport to failed failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-failed failed
# Navigate to the new working tree
pushd ../.worktrees/backport-failed
# Create a new branch
git switch --create backport/backport-789-to-failed
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 46da4697edb1865ccd6f58fcf9fe67c592e3be85
# Push it to GitHub
git push --set-upstream origin backport/backport-789-to-failed
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-failed

Then, create a pull request where the base branch is failed and the compare/head branch is backport/backport-789-to-failed.

@bbarani
Copy link
Member

bbarani commented May 26, 2023

This PR shouldn't have been merged until the maintainers are added to the repo. @ashwin-pc @joshuarrrr . Code owners is still not green.

Screen Shot 2023-05-26 at 1 17 11 PM

@BSFishy BSFishy deleted the add_maintainers2 branch June 20, 2023 00:06
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 20, 2023
Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit 46da469)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit 46da469)

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants