-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @andreymyssak and @SergeyMyssak as co-maintainers #789
Conversation
Signed-off-by: Matt Provost <provomat@amazon.com>
| Andrey Myssak | [andreymyssak](https://github.com/andreymyssak) | | | ||
| Sergey Myssak | [SergeyMyssak](https://github.com/SergeyMyssak) | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreymyssak @SergeyMyssak Do you want anything for affiliation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSFishy I think we can leave it blank for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add affiliation as "external contributor" similar to https://github.com/opensearch-project/terraform-provider-opensearch/blob/main/MAINTAINERS.md?
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-789-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 46da4697edb1865ccd6f58fcf9fe67c592e3be85
# Push it to GitHub
git push --set-upstream origin backport/backport-789-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-failed failed
# Navigate to the new working tree
pushd ../.worktrees/backport-failed
# Create a new branch
git switch --create backport/backport-789-to-failed
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 46da4697edb1865ccd6f58fcf9fe67c592e3be85
# Push it to GitHub
git push --set-upstream origin backport/backport-789-to-failed
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-failed Then, create a pull request where the |
This PR shouldn't have been merged until the maintainers are added to the repo. @ashwin-pc @joshuarrrr . Code owners is still not green. ![]() |
Signed-off-by: Matt Provost <provomat@amazon.com> (cherry picked from commit 46da469) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 46da469) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Following the process in
opensearch-project/.github/RESPONSIBILITIES.md
, I had nominated Andrey and Sergey Myssak (@andreymyssak and @SergeyMyssak) as co-maintainers. The maintainers have voted and agreed to this nomination.I would like to nominate Sergey (SergeyMyssak on Github) and Andrey (andreymyssak on Github) as maintainers for OUI. They have made numerous contributions to OUI, including but not limited to helping fix issues in backports (#757), auditing usage of outdated dependencies and creating action items to remedy (#594 (comment)), and establishing a deprecation precedent for components (#606).
I see that opensearch-js has already accepted a CCI contributor as a maintainer so I don’t see any reason why we too shouldn’t 😊 . +1 to both since of the 22 merged CCI PR’s, they have contributed 19 of those PR.
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.