Enable local consumption of OUI #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
seanneumann,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
BSFishy
reviewed
Jun 19, 2023
With the upgrade os `eslint`, the location of the default formatter changed. This is just a hack to work around the problem in the now abandoned `sass-lint`. Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
enable-local-dev
branch
from
84a0b0a to
72cf106
Compare
manasvinibs
reviewed
Jun 19, 2023
| @@ -14,7 +14,7 @@ packages/eslint-plugin | |||
| types/ | |||
|
|
|||
| # ignore everything in `scripts` except postinstall.js | |||
| scripts/!(postinstall.js) | |||
| scripts/!(postinstall.js|preinstall.js) | |||
There was a problem hiding this comment.
nit: can we update the comment here to include preinstall as well?
manasvinibs
reviewed
Jun 19, 2023
|
|
||
| // Only run when installed as a dep | ||
| if (!INIT_CWD?.startsWith?.(PWD)) { | ||
| const depsToKeep = [ |
There was a problem hiding this comment.
Just curious to know how did we determine this list of deps and know we haven't missed any?
There was a problem hiding this comment.
Left a comment in the code:
/* These are deps and types which get installed when a production package is installed.
* When this library is linked as a dep to another project, having all the deps could
* confuse or conflict the project's compilers.
*
* When being installed as dep of another project in production, `node_modules` would
* be empty.
*/
| 'docs', | ||
| 'generator-oui', | ||
| 'packages/eslint-plugin', | ||
| 'packages/react-datepicker', |
There was a problem hiding this comment.
We never use the content of packages/react-datepicker; it is only the built artifact, packages/react-datepicker.js that we package and consume.
|
Is there a |
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
enable-local-dev
branch
from
72cf106 to
91161be
Compare
BSFishy
approved these changes
Jun 19, 2023
manasvinibs
approved these changes
Jun 19, 2023
bandinib-amzn
approved these changes
Jun 19, 2023
In the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Fix linting sass files With the upgrade os `eslint`, the location of the default formatter changed. This is just a hack to work around the problem in the now abandoned `sass-lint`. Signed-off-by: Miki <miki@amazon.com> * Add preinstall script Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 2c26b04) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Fix linting sass files With the upgrade os `eslint`, the location of the default formatter changed. This is just a hack to work around the problem in the now abandoned `sass-lint`. * Add preinstall script --------- (cherry picked from commit 2c26b04) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows OUI to self-clean while being installed during development when linked to as a dependency.
Also:
Issues Resolved
[List any issues this PR will resolve]
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.