Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version to 18.16.0 #900

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Jul 20, 2023

Description

Bumped Node version to 18.16.0. All steps:

  • Bump nvmrc version to 18.16.0
  • Bump version of fork-ts-checker-webpack-plugin, otherwise build fails due to RPC issues
  • Change webpack to patched version that supports Node 18 with hash module changes

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Copy link
Collaborator

@SergeyMyssak SergeyMyssak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Signed-off-by: Matt Provost <provomat@amazon.com>
@joshuarrrr
Copy link
Member

Build succeeded and Build Docs failed, which is to be expected.

@joshuarrrr joshuarrrr merged commit 1ff6493 into opensearch-project:main Aug 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 16, 2023
* Bump node version to 18.16.0

Signed-off-by: Matt Provost <provomat@amazon.com>

* Update changelog

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit 1ff6493)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@BSFishy BSFishy deleted the bump_node branch August 16, 2023 19:18
BSFishy added a commit to BSFishy/oui that referenced this pull request Aug 16, 2023
* Bump node version to 18.16.0

Signed-off-by: Matt Provost <provomat@amazon.com>

* Update changelog

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
BSFishy pushed a commit that referenced this pull request Aug 21, 2023
* Bump node version to 18.16.0

Signed-off-by: Matt Provost <provomat@amazon.com>

* Update changelog

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit 1ff6493)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants