Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Saved Objects import feature improves information transfer for multiple data sources #2572

Merged
merged 28 commits into from
Feb 22, 2024

Conversation

yujin-emma
Copy link
Contributor

Description

When multiple data source feature is enabled, user can add sample data and use the opensearch-project/OpenSearch-Dashboards#3806 with one connected data source. Import saved objects accepts uploaded files, but the API does not know the data source. These objects cannot display correctly since the it does not know where to fetch the data.
We want to provide user the ability to specify a data source when importing saved objects. When user import saved object without any data source information, the imported saved objects will attach the specified dataSourceId with the objectId; while user import saved objects different data source information ( e.g. user can connect with dataSource1 and some exported saved objects from dataSource2 ), then the objectId would already contains data source info ( dataSource2 ), for this case, we will replace the dataSourceId. The id schema are exactly same as when user add sample data and dev tools with multiple data source enabled. The behavior will keep consistent for users.

Issues Resolved

#2568

Check List

  • [ X ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

…t.md

Add post md file

Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md

Add gif for demo

Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md

Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md

Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md

Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md

Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yujin-emma Editorial review is complete. Nice job on this 😄. Please see my comments and changes and let me know if you have any questions.

@vagimeli Thank you for your support on this and ensuring consistency between the documentation and the blog post.

@pajuric This is ready to be published once my comments and changes are addressed. Thanks!

yujin-emma and others added 7 commits February 9, 2024 12:54
…d-object.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…t.md

Update publish date to 02-22 as required and also update the meta keywords and description

Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
@pajuric
Copy link

pajuric commented Feb 21, 2024

@nateynateynate @krisfreedain @dtaivpp - This blog is ready to publish on Thursday, February 22 in the morning.

@seraphjiang
Copy link
Member

seraphjiang commented Feb 22, 2024

@pajuric @yujin-emma @BionIT could we correct the title of the blog, remove the connections

Enhancing multiple data sources connections through Saved Objects import functionality

@yujin-emma yujin-emma changed the title Enhancing multiple data sources connections through Saved Objects import functionality The Saved Objects import feature improves information transfer for multiple data sources Feb 22, 2024
Copy link
Collaborator

@dtaivpp dtaivpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtaivpp dtaivpp merged commit d4509ae into opensearch-project:main Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants