-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Saved Objects import feature improves information transfer for multiple data sources #2572
Conversation
…t.md Add post md file Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md Add gif for demo Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…t.md Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yujin-emma Editorial review is complete. Nice job on this 😄. Please see my comments and changes and let me know if you have any questions.
@vagimeli Thank you for your support on this and ensuring consistency between the documentation and the blog post.
@pajuric This is ready to be published once my comments and changes are addressed. Thanks!
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
…d-object.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…d-object.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Outdated
Show resolved
Hide resolved
_posts/2024-02-08-enhancement-multiple-data-source-import-saved-object.md
Show resolved
Hide resolved
…t.md Update publish date to 02-22 as required and also update the meta keywords and description Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
@nateynateynate @krisfreedain @dtaivpp - This blog is ready to publish on Thursday, February 22 in the morning. |
@pajuric @yujin-emma @BionIT could we correct the title of the blog, remove the connections Enhancing multiple data sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
When multiple data source feature is enabled, user can add sample data and use the opensearch-project/OpenSearch-Dashboards#3806 with one connected data source. Import saved objects accepts uploaded files, but the API does not know the data source. These objects cannot display correctly since the it does not know where to fetch the data.
We want to provide user the ability to specify a data source when importing saved objects. When user import saved object without any data source information, the imported saved objects will attach the specified dataSourceId with the objectId; while user import saved objects different data source information ( e.g. user can connect with dataSource1 and some exported saved objects from dataSource2 ), then the objectId would already contains data source info ( dataSource2 ), for this case, we will replace the dataSourceId. The id schema are exactly same as when user add sample data and dev tools with multiple data source enabled. The behavior will keep consistent for users.
Issues Resolved
#2568
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.