-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arch Linux artifacts #642
Add Arch Linux artifacts #642
Conversation
I don't this older versions should be included here. Only the version in the official repositories (the latest) is the one Arch Linux will support. |
That sounds reasonable. I guess every merge request should remove the old (unsupported) version. Since we then provide only one version we should also link to the package pages. |
55bd160
to
16bbad1
Compare
@hashworks This amazing! I'm working on some refactoring of the downloads page so I'm holding on merging this one for a little bit (merging makes it go live in the deployment pipeline). |
Hi @hashworks - first, I wanted to thank you for your contribution! I was quite pleased to see this PR come in. I was wondering if you could help me here. I'm going through an install on my own Archlinux box just for a sanity check, and I didn't have any luck getting dashboards to run (it installed fine). I kept getting this error: When clicking through the dependencies at https://archlinux.org/packages/community/x86_64/opensearch-dashboards/, I noticed that it has a requirement for https://archlinux.org/packages/community/x86_64/nodejs-lts-erbium/ which is at 12.22.9, but OpenSearch Dashboards requires 12.22.8 to run. Are you seeing this same issue at all? |
I'm sorry, this must have slipped by me. Please try out the new Since we only package the LTS versions of node and For now, I've removed var isVersionValid = requiredVersion.match(/^v(\d+\.\d+)/)[1] === currentVersion.match(/^v(\d+\.\d+)/)[1] But let's discuss that in another issue. Do you want people to be notified about the adjusted NodeJS version on the download page? |
Removes the runtime nodejs version check, see: opensearch-project/project-website#642 git-svn-id: file:///srv/repos/svn-community/svn@1118307 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Removes the runtime nodejs version check, see: opensearch-project/project-website#642 git-svn-id: file:///srv/repos/svn-community/svn@1118307 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Thanks for the update @hashworks. I think we might have an opportunity for collaboration here. We'd really love to see the post-install experience to match what is currently distributed by the project, but I can't help but notice a bit of divergence. It might be good to explore together how we can fill in the gaps for the Arch users so they can get up and running in a way that matches the OpenSearch documentation more closely in the areas around security and configuration. Glad to work with you on this or hear your thoughts on what would be idiomatic for Arch users. |
If you list the divergences you noticed I would happily address them or provide reasoning for the adjustments :)
I guess the basic idiom is simplicity. Arch users expect the installed packages to be as close to upstream as possible without unnecessary additions or modifications, including configuration files. All adjustments should be distro related, not something the packager "prefers". We also want to ensure flexibility – if users decide that they don't need a security plugin they should be able to do so, which is why the plugins are provided as separate packages. Therefore, the upstream configuration file is used without any modifications. For opensearch-dashboards a single adjustment is made since we expect users to run it using the provided systemd service. sed -r 's|#(logging.quiet:) false|\1 true|' -i config/opensearch_dashboards.yml |
@hashworks OK. I get where you're coming from with regards to packaging & thanks for explaining the Arch philosophy. I think the rub is with the packaging - individual plugins vs together as a single unit. Currently, OpenSearch does distribute a
Point 1 is easier to bridge. One thing that comes to mind is making the downloadable artifact on the website a script that uses Point 2 is tougher. While breaking changes happen all the time across a distro - I'd anticipate the combination of how OpenSearch is broken up now vs where it's heading causing more headaches that love for arch users. I'd be very interested how there could be collaboration in making this a smooth transition for everyone. Thoughts on any of this? |
Sorry for the silence, I've been a bit busy.
I don't think this is something Arch users expect. I also suspect most will refer to the official documentation for specific needs, not for an installation guide. However, I get your point – if we want to unify the experience I guess it would be best to install all plugins when one calls But: Doing so now might break existing installations. If someone isn't using the security plugin, installing it now would break their setup:
The Do you think it would be reasonable to only provide an Arch option in the "OpenSearch Minimum" section? Alternatively I could add a warning to the current state. |
@peternied WDYT ^? |
First off - this is amazingly cool!
I'm not sure if disabling the feature is correct vs making TLS configuration have better defaults; however, this is a great issue for us to tackle. I've created opensearch-project/security#1631
I like this idea, a logical framework that can be consistent even if we reshape the 'physical' layout of plugins. |
Can this be merged (soon)? We're talking about Arch Linux in #670 |
a2b52af
to
8a02ab0
Compare
Since #1631 has been closed, I won't add such a drastic change (which might break current installations). Any other way we could merge this? Adjustments to the text, additional warnings, wiki-notes, … |
8a02ab0
to
62c55fb
Compare
Signed-off-by: Justin Kromlinger <hashworks@archlinux.org>
Signed-off-by: Justin Kromlinger <hashworks@archlinux.org>
Signed-off-by: Justin Kromlinger <hashworks@archlinux.org>
Signed-off-by: Justin Kromlinger <hashworks@archlinux.org>
62c55fb
to
50d2413
Compare
What should we do with this PR? If this will never be merged I can stop adding the new versions. |
aae1a89
to
7b27e5f
Compare
Signed-off-by: Justin Kromlinger <hashworks@archlinux.org>
7b27e5f
to
4bf14a0
Compare
Hello @hashworks - I've recently taken over the site maintenance from @stockholmux and need to look into this. OK if I read through and work to get back to you soon? Your work on this is greatly appreciated. |
Sure! |
Anyone looking in to this PR? @krisfreedain @stockholmux |
Can I get an assist on whomever is involved here on what the next steps are? @dblock, @peternied, @hashworks, @bbarani ? It would seem that Arch Linux has some requirements for their packages being as minimal as possible. I'd sure like to get this one merged some day. |
@nateynateynate @kaimmej - can we look at this one this week? I think we're at a place where this distro needs to be included in the download each time - looks like the team is doing a build each time - thanks |
Ok it looks like you're live from #3117 Enjoy! :-) |
Description
Adds artifacts for the official Arch Linux OpenSearch packages.
As discussed with @stockholmux by mail.
The Arch Linux packages I created do stuff a bit differently than the archives you normally provide. The
opensearch
package is minimal by default, without any plugins. Those are available as additional packages. Therefore, I would provide the installation instructions like this:Same goes for OpenSearch Dashboards:
If you think this doesn't suit you we can provide the Arch Linux platform on the "Minimal Distributions" list only.