-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Integtest.sh for OpenSearch integtest setups #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, thanks
integtest.sh
Outdated
fi | ||
|
||
|
||
if [ "$DIRECTORY" = "dashboards-notebooks" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be dashboards-reports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
=========================================
Coverage 63.41% 63.41%
Complexity 309 309
=========================================
Files 101 101
Lines 4401 4401
Branches 669 669
=========================================
Hits 2791 2791
Misses 1442 1442
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change directory check to dashboards-reports
as per Josh's comment- other than that, LGTM
777a7f7
29c819b
to
777a7f7
Compare
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
938611f
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…ts into opensearch-integtest-demo Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…nsearch-integtest-demo Add Integtest.sh for OpenSearch integtest setups
…demo (#146) Add Integtest.sh for OpenSearch integtest setups Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
* Add release notes for 2.8 (opensearch-project#124) (opensearch-project#126) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 8fc812752807ff92a8dc96f2e22e666d03c0b23e) Co-authored-by: Joshua Li <joshuali925@gmail.com> * Increment version to 2.8.0.0 Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> --------- Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Add Integtest.sh for OpenSearch integtest setups
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.