Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integtest.sh for OpenSearch integtest setups #121

Merged
merged 4 commits into from
Jul 10, 2021

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Add Integtest.sh for OpenSearch integtest setups

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

joshuali925
joshuali925 previously approved these changes Jul 9, 2021
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, thanks

integtest.sh Outdated
fi


if [ "$DIRECTORY" = "dashboards-notebooks" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be dashboards-reports?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

Merging #121 (ae32282) into main (48570bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #121   +/-   ##
=========================================
  Coverage     63.41%   63.41%           
  Complexity      309      309           
=========================================
  Files           101      101           
  Lines          4401     4401           
  Branches        669      669           
=========================================
  Hits           2791     2791           
  Misses         1442     1442           
  Partials        168      168           
Flag Coverage Δ
dashboards-reports 76.01% <ø> (ø)
reports-scheduler 53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48570bd...ae32282. Read the comment docs.

davidcui1225
davidcui1225 previously approved these changes Jul 9, 2021
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change directory check to dashboards-reports as per Josh's comment- other than that, LGTM

@peterzhuamazon peterzhuamazon dismissed stale reviews from davidcui1225 and joshuali925 via 777a7f7 July 9, 2021 23:43
@peterzhuamazon peterzhuamazon force-pushed the opensearch-integtest-demo branch from 29c819b to 777a7f7 Compare July 9, 2021 23:43
joshuali925
joshuali925 previously approved these changes Jul 9, 2021
davidcui1225
davidcui1225 previously approved these changes Jul 9, 2021
zhongnansu
zhongnansu previously approved these changes Jul 10, 2021
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…ts into opensearch-integtest-demo

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit 237a822 into main Jul 10, 2021
joshuali925 pushed a commit to joshuali925/reporting that referenced this pull request Aug 30, 2021
…nsearch-integtest-demo

Add Integtest.sh for OpenSearch integtest setups
joshuali925 added a commit that referenced this pull request Aug 31, 2021
…demo (#146)

Add Integtest.sh for OpenSearch integtest setups

Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
kavilla pushed a commit to kavilla/dashboards-reports that referenced this pull request Jul 12, 2023
* Add release notes for 2.8 (opensearch-project#124) (opensearch-project#126)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 8fc812752807ff92a8dc96f2e22e666d03c0b23e)

Co-authored-by: Joshua Li <joshuali925@gmail.com>

* Increment version to 2.8.0.0

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>

---------

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants