Taking RBAC settings from Alerting plugin default to false

[akbhatta]

Description

1. Taking RBAC settings from Alerting plugin default to false
2. Legacy settings removed because all relevant settings are removed or taken from Alerting plugin
3. Poll API removed as it is not used

[Tests]
All existing tests passed

Signed-off-by: @akbhatta

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #165 (1b08bff) into main (dc55f62) will increase coverage by 2.59%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##               main     #165      +/-   ##
============================================
+ Coverage     62.42%   65.01%   +2.59%     
+ Complexity      309      292      -17     
============================================
  Files           101       96       -5     
  Lines          4484     4053     -431     
  Branches        681      632      -49     
============================================
- Hits           2799     2635     -164     
+ Misses         1517     1277     -240     
+ Partials        168      141      -27     

Flag	Coverage Δ
dashboards-reports	73.30% <ø> (ø)
reports-scheduler	56.69% <63.63%> (+3.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nsearch/reportsscheduler/ReportsSchedulerPlugin.kt	100.00% <ø> (ø)
...rch/reportsscheduler/index/ReportInstancesIndex.kt	59.00% <ø> (+12.54%)	⬆️
.../reportsscheduler/model/ReportDefinitionDetails.kt	75.40% <ø> (+1.21%)	⬆️
...n/org/opensearch/reportsscheduler/model/RestTag.kt	100.00% <ø> (ø)
...rch/reportsscheduler/security/UserAccessManager.kt	16.66% <0.00%> (+6.94%)	⬆️
...search/reportsscheduler/settings/PluginSettings.kt	72.13% <88.23%> (+1.64%)	⬆️
...reportsscheduler/action/ReportDefinitionActions.kt	75.00% <100.00%> (ø)
...h/reportsscheduler/action/ReportInstanceActions.kt	73.33% <100.00%> (+11.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc55f62...1b08bff. Read the comment docs.

[joshuali925]

would this break upgrades from opendistro?

[akbhatta]

we are completely removing support for filtering based on this setting because we need to support compatibility with notification plugin. Remaining settings are relevant for admin/maintainers only

[zhongnansu]

lgtm
Could you create an issue for removing the polling related code in dashboard-reporting plugin and assign to me?

[akbhatta]

lgtm
Could you create an issue for removing the polling related code in dashboard-reporting plugin and assign to me?

#166