Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 2.0.0 #311

Merged
merged 6 commits into from
Mar 24, 2022
Merged

Bump version to 2.0.0 #311

merged 6 commits into from
Mar 24, 2022

Conversation

eugenesk24
Copy link
Contributor

Signed-off-by: Eugene Lee eugenesk@amazon.com

Description

Bump version to 2.0.0

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eugenesk24
Bump version to 2.0
0efb09c 
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@eugenesk24 eugenesk24 requested a review from a team as a code owner March 21, 2022 18:04
zhongnansu
zhongnansu suggested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reports-dashbaords CI failed, please check. I'd also suggest that you post draft PR first and make sure all github actions pass, no reviewers will be notified for a draft PR, you can make any modifications. Then you can convert to regular PR and request reviews.

dashboards-reports/test/jest.config.js
@@ -19,4 +19,5 @@ module.exports = {
'\\.(css|less|sass|scss)$': '<rootDir>/test/__mocks__/styleMock.js',
'\\.(gif|ttf|eot|svg)$': '<rootDir>/test/__mocks__/fileMock.js',
},
testEnvironment: 'jsdom',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuali925 This was added in sql so I added just in case but I am not sure if it is needed in reporting. opensearch-project/dashboards-visualizations#56 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does removing this testEnvironment config help unblock the front-end CI workflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it did not

@eugenesk24 eugenesk24 marked this pull request as draft March 21, 2022 18:51
@eugenesk24
Revert jest config for build failure
248dfa2 
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #311 (100cba9) into main (2e904c5) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #311      +/-   ##
============================================
- Coverage     73.01%   72.64%   -0.37%     
  Complexity      373      373              
============================================
  Files            94       94              
  Lines          3928     3963      +35     
  Branches        609      644      +35     
============================================
+ Hits           2868     2879      +11     
- Misses          885      909      +24     
  Partials        175      175
Flag Coverage Δ
dashboards-reports 76.69% <ø> (-0.85%) ⬇️
reports-scheduler 68.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dashboards-reports/public/components/main/main.tsx 56.73% <0.00%> (-7.00%) ⬇️
...s-reports/server/routes/utils/dataReportHelpers.ts 92.38% <0.00%> (-1.62%) ⬇️
...orts/server/routes/utils/converters/backendToUi.ts 68.54% <0.00%> (-1.13%) ⬇️
...rt_definitions/report_settings/report_settings.tsx 80.13% <0.00%> (-1.02%) ⬇️
...port_definitions/report_trigger/report_trigger.tsx 72.48% <0.00%> (-0.89%) ⬇️
...ards-reports/public/components/main/main_utils.tsx 71.69% <0.00%> (-0.69%) ⬇️
...itions/report_settings/report_settings_helpers.tsx 84.88% <0.00%> (-0.49%) ⬇️
...t_definition_details/report_definition_details.tsx 70.61% <0.00%> (-0.26%) ⬇️
...rts/server/routes/utils/savedSearchReportHelper.ts 98.76% <0.00%> (+0.01%) ⬆️
...ashboards-reports/server/utils/validationHelper.ts 92.15% <0.00%> (+0.15%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e904c5...100cba9. Read the comment docs.

eugenesk24 and others added 4 commits March 21, 2022 14:04
@eugenesk24
Use dashboards 1.3 for build
b5063b3 
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@eugenesk24
Bump node version
6707fac 
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@davidcui1225
resolve package conflict versions
c3233cb 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
update main test to use done() instead of both done() and async/await
100cba9 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
Copy link
Contributor

All workflows are passing now- @eugenesk24 any other steps needed before making this PR ready for review?

@eugenesk24 eugenesk24 marked this pull request as ready for review March 23, 2022 23:59
@davidcui1225 davidcui1225 merged commit a3adae8 into opensearch-project:main Mar 24, 2022
kavilla pushed a commit to kavilla/dashboards-reports that referenced this pull request Jul 12, 2023
@eugenesk24 @davidcui1225
Bump version to 2.0.0 (opensearch-project#311)
df60a31 
* Bump version to 2.0

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

Co-authored-by: David Cui <davidcui@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongnansu zhongnansu zhongnansu approved these changes

@davidcui1225 davidcui1225 davidcui1225 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eugenesk24 @codecov-commenter @davidcui1225 @zhongnansu