Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.3.1 #323

Closed
wants to merge 1 commit into from
Closed

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Mar 26, 2022

Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com

Description

Bump version to 1.3.1

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya gaiksaya requested a review from a team as a code owner March 26, 2022 00:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #323 (a068f34) into 1.3 (fec1eaf) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #323      +/-   ##
============================================
- Coverage     73.01%   72.86%   -0.16%     
  Complexity      373      373              
============================================
  Files            94       94              
  Lines          3928     3928              
  Branches        609      609              
============================================
- Hits           2868     2862       -6     
- Misses          885      891       +6     
  Partials        175      175              
Flag Coverage Δ
dashboards-reports 77.21% <ø> (-0.33%) ⬇️
reports-scheduler 68.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dashboards-reports/public/components/main/main.tsx 57.84% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec1eaf...a068f34. Read the comment docs.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does reports-scheduler (reporting opensearch plugin) also need the bump?

@@ -1,6 +1,6 @@
{
"id": "reportsDashboards",
"version": "1.3.0.0",
"version": "1.3.1.0",
"opensearchDashboardsVersion": "1.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashboards core not 1.3.1?

Copy link
Member Author

@gaiksaya gaiksaya Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No just opensearch component. No dashboard release for this one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then this PR should not bump reportsDashboards?

@gaiksaya
Copy link
Member Author

gaiksaya commented Mar 29, 2022

Thanks for pointing that out @joshuali925 . Please see #324 for updated PR. Thanks!

@gaiksaya gaiksaya closed this Mar 29, 2022
@gaiksaya gaiksaya deleted the 1.3.1 branch March 29, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants