Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating 1.x branch with latest from 1.3.x #403

Merged
merged 147 commits into from
Jul 28, 2022
Merged

Updating 1.x branch with latest from 1.3.x #403

merged 147 commits into from
Jul 28, 2022

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jul 28, 2022

Description

Updating 1.x branch with latest from 1.3.x

Issues Resolved

#396

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

zhongnansu and others added 30 commits April 27, 2021 14:04
@zhongnansu
Fix release notes version (#28)
806c2c6 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
Migrate Reporting Notebooks Integration (#21)
047b54c 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
Add Logic to Auto-populate Notebooks from Context Menu (#30)
08fded0 
Signed-off-by: David Cui <davidcui@amazon.com>
@joshuali925
Change opendistro to opensearch in email template (#31)
41dd2a5 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@davidcui1225 @CarlMeadows
@zhongnansu @joshuali925
Fix case sensitive directory name for chromium zip (#35)
17443d9 
Signed-off-by: David Cui <davidcui@amazon.com>

Co-authored-by: Carl Meadows <47793022+CarlMeadows@users.noreply.github.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
@davidcui1225
Use output_only Parameter for notebook reports (#32)
9d5e1a1 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
replace osd-version header to remove need for version number matching (…
8f2197d 
…#37)

Signed-off-by: David Cui <davidcui@amazon.com>
@joshuali925
Remove visualization editor in visualization reports (#50)
dd6e3b2 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@davidcui1225
add condition to fix negative value display (#51)
1ba1ad7 
Signed-off-by: David Cui <davidcui@amazon.com>
@MKCG
[Query Builder] Correctly handle match phrases when a single value is…
0399724 
… specified or when the match phrases is negated (#33)

* [Build query] Correctly handle phrases filter that specify only one single value

Contrary to the phrase filter type which always specify a meta.params.query, the phrases filter type never specify a meta.params.query even when a single value is selected.
This anomaly trigger an error generated by the MonoFieldQueryBase included in the elastic-builder dependency and prevent the generation of the report.

Signed-off-by: Kévin Masseix <masseix.kevin@gmail.com>

* [Build query] Correctly handle negated phrases filter that specify only one single value

Signed-off-by: Kévin Masseix <masseix.kevin@gmail.com>

* [Build query] Correctlty handle negated phrases to exclude them from the report instead of including them

Signed-off-by: Kévin Masseix <masseix.kevin@gmail.com>
@uzhinskiy @zhongnansu
Pass processing if doc[field] == null (#361)
22e5489 
Pass processing if doc[field] == null
Based on opendistro-for-elasticsearch/kibana-reports#327 (comment)
@zhongnansu
add test case for commit 368eb03e200b755870f1ad373e67561201ab6f31 (#370)
19ca93a 
Add missing test case for the fix "pass doc[field] == null"
@zhongnansu
Unhash page url in case store URLs in session storage is enabled from…
1260f6b 
… Kibana advanced setting (#371)
@davidcui1225
Update Namespaces/APIs/Documentation for OpenSearch (#55)
fa2d7dc 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
bump path-parse version to 1.0.7 to address CVE (#59)
b43e33e 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
merge main into dev
31bbecb 
Signed-off-by: David Cui <davidcui@amazon.com>
@zhongnansu
increase chromium timeout to 100s (#58)
f517f3f 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@joshuali925
Fix csv parsing function (#53)
83bf1b4 
* Fix csv parsing function

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Flatten nested results for csv

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add test case for nested fields

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@davidcui1225
Add release notes for rc1 (#60)
4a791ae 
Signed-off-by: David Cui <davidcui@amazon.com>
@zhongnansu
configure index settings to have default 1 replica and auto-expand up…
2341aaa 
…perbound 2 (#62)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
Rc1 release note patch (#63)
b88adc3 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
Bump OpenSearch Dashboards version to 1.0 (#64)
c325710 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix merge conflict in readme
8c3b56f 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
Revert .opensearch_dashboards index references to .kibana (#67)
5ba1a9d 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
Add diagrams for integration with Notifications plugin (#75)
960bcaa 
* add puml diagrams for integration with Notifications plugin
Signed-off-by: David Cui <davidcui@amazon.com>

* amend Notifications plugin naming in diagram
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
merge changes from main
c2c43bd 
Signed-off-by: David Cui <davidcui@amazon.com>
@starcatter @zhongnansu
Add i18n translation support (#362)
7e326be
@iget-esoares @zhongnansu
PDF report is no more a screenshot, increasing the overall quality
6933dd4 
Also a issue with chrome font rendering was fixed
@davidcui1225
Add Notifications to docs (#87)
f3d5167 
* moved docs to root folder, update readme to include Notifications roadmap
Signed-off-by: David Cui <davidcui@amazon.com>

* update readme to clarify current status of supported features
Signed-off-by: David Cui <davidcui@amazon.com>
@zhongnansu
Better support sorting for csv report based on saved search (#86)
62be0df
davidcui1225 and others added 21 commits February 23, 2022 16:53
@davidcui1225
add auto-backport functionality for reporting (#286)
3b03b70 
Add auto-backport and auto-delete workflows for reporting

Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
Change Default CI version to JDK 11 (#290)
f581454 
* change default CI version to JDK 11, add JDK versions to CI matrix and document changes in developer guide

Signed-off-by: David Cui <davidcui@amazon.com>
@zhongnansu
remove incorrect tag form issue template (#294)
a84e4b1 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@zhongnansu
Fix empty or multiple date values in csv (#293)
d444010 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@zhongnansu
Update the saved object id matcher regex to match custom id (#295)
162373e 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
Replace Centos links to fix link checker CI (#297)
075f5ac 
exclude centos links from linkchecker

Signed-off-by: David Cui <davidcui@amazon.com>
@zhongnansu
update regex to match custom saved object id (#298)
d28fdd4 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@joshuali925
Fix reporting uuid parsing (#300)
265e2a7 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@opensearch-trigger-bot @zhongnansu
Add java 8 support in compile and test (#304) (#305)
d52091c 
* add java 8 support in compile and test

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit e753b07)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
@opensearch-trigger-bot @zhongnansu
Add 1.3 release notes (#307) (#308)
fec1eaf 
* Add 1.3 release notes

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 2e904c5)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
@gaiksaya
Bump version to 1.3.1 (#324)
50cb45b 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@joshuali925
Bump reports dashboards to 1.3.1 (#331)
41c0795 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@zelinh
Incremented version to 1.3.2. (#352)
c960d80 
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@prudhvigodithi
Version bump 1.3.3
3bb28d1 
Signed-off-by: pgodithi <pgodithi@amazon.com>
@prudhvigodithi
Version bump 1.3.3
a14baf1 
Signed-off-by: pgodithi <pgodithi@amazon.com>
@prudhvigodithi
Version bump 1.3.3
8209900 
Signed-off-by: pgodithi <pgodithi@amazon.com>
@anirudha
Merge pull request #366 from prudhvigodithi/1.3.3-versionbump
1d72c3f 
Version Increment to 1.3.3 OpenSearch release
@joshuali925
[1.3] Bump minimist to 1.2.6 (#367)
7c92fc8 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 @davidcui1225
Move HTML sanitization from client to server side (#382) (#386)
00ba034 
Move HTML sanitization to server, store markdown over HTML, remove unused imports

Signed-off-by: David Cui <davidcui@amazon.com>

Co-authored-by: David Cui <53581635+davidcui1225@users.noreply.github.com>
@zelinh
Incremented version to 1.3.4. (#389)
f066c65 
* Incremented version to 1.3.4.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Add JS snapshot

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@opensearch-trigger-bot @joshuali925
Add release notes for 1.3.4.0 (#393) (#394)
072ac50 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 8e01eaa)

Co-authored-by: Joshua Li <joshuali925@gmail.com>
@ps48 ps48 requested review from joshuali925 and kavithacm July 28, 2022 05:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (1.x@d08711e). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             1.x     #403   +/-   ##
======================================
  Coverage       ?   72.95%           
  Complexity     ?      373           
======================================
  Files          ?       94           
  Lines          ?     3946           
  Branches       ?      611           
======================================
  Hits           ?     2879           
  Misses         ?      892           
  Partials       ?      175
Flag Coverage Δ
dashboards-reports 77.38% <0.00%> (?)
reports-scheduler 68.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ps48 ps48 requested a review from davidcui1225 July 28, 2022 16:42
davidcui1225
davidcui1225 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I see the DCO check failed

@ps48
Copy link
Member Author

ps48 commented Jul 28, 2022

LGTM but I see the DCO check failed

Those are for older commits, should be fine.

@ps48 ps48 merged commit febb923 into 1.x Jul 28, 2022
@vmmusings vmmusings mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcui1225 davidcui1225 davidcui1225 approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.