Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 1.x] Enable windows build #561

Merged
merged 5 commits into from
Dec 2, 2022
Merged

[backport 1.x] Enable windows build #561

merged 5 commits into from
Dec 2, 2022

Conversation

rupal-bq
Copy link
Contributor

@rupal-bq rupal-bq commented Dec 2, 2022

Description

Enable windows build

Issues Resolved

#547

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho and others added 5 commits December 2, 2022 18:22
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@rupal-bq rupal-bq requested a review from a team as a code owner December 2, 2022 19:38
@codecov-commenter
Copy link

Codecov Report

Merging #561 (2bd0b86) into 1.x (d3f36b5) will increase coverage by 2.49%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x     #561      +/-   ##
============================================
+ Coverage     74.57%   77.06%   +2.49%     
============================================
  Files            94       30      -64     
  Lines          4008     1910    -2098     
  Branches        612      383     -229     
============================================
- Hits           2989     1472    -1517     
+ Misses          885      435     -450     
+ Partials        134        3     -131     
Flag Coverage Δ
dashboards-reports 77.06% <ø> (ø)
reports-scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/org/opensearch/reportsscheduler/model/RestTag.kt
...heduler/model/UpdateReportInstanceStatusRequest.kt
...tsscheduler/action/UpdateReportDefinitionAction.kt
...tsscheduler/action/CreateReportDefinitionAction.kt
...sscheduler/model/UpdateReportDefinitionResponse.kt
...sscheduler/action/GetAllReportDefinitionsAction.kt
...search/reportsscheduler/model/ReportInstanceDoc.kt
...uler/resthandler/RestResponseToXContentListener.kt
...reportsscheduler/action/GetReportInstanceAction.kt
...heduler/resthandler/ReportDefinitionRestHandler.kt
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rupal-bq rupal-bq requested a review from joshuali925 December 2, 2022 20:19
@rupal-bq rupal-bq merged commit 6efd7b1 into opensearch-project:1.x Dec 2, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-561-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6efd7b11d169f86a1e3212717f2c1bff79b20495
# Push it to GitHub
git push --set-upstream origin backport/backport-561-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-561-to-1.3.

@rupal-bq rupal-bq changed the title [backport 1.3] Enable windows build [backport 1.x] Enable windows build Dec 2, 2022
rupal-bq added a commit that referenced this pull request Dec 2, 2022
* feat: enable windows and macos build (#504)

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove macos

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove macos from dashboards report

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix build

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Update setup node for linux

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Co-authored-by: Derek Ho <derek01778@gmail.com>
(cherry picked from commit 6efd7b1)
@rupal-bq rupal-bq deleted the windows-backport branch December 13, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants