-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport 1.x] Enable windows build #561
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.x #561 +/- ##
============================================
+ Coverage 74.57% 77.06% +2.49%
============================================
Files 94 30 -64
Lines 4008 1910 -2098
Branches 612 383 -229
============================================
- Hits 2989 1472 -1517
+ Misses 885 435 -450
+ Partials 134 3 -131
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-561-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6efd7b11d169f86a1e3212717f2c1bff79b20495
# Push it to GitHub
git push --set-upstream origin backport/backport-561-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
* feat: enable windows and macos build (#504) Signed-off-by: Derek Ho <dxho@amazon.com> * Remove macos Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove macos from dashboards report Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix build Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update setup node for linux Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Derek Ho <derek01778@gmail.com> (cherry picked from commit 6efd7b1)
Description
Enable windows build
Issues Resolved
#547
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.