-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.3] Use front-end report generation instead of chromium #611
Merged
rupal-bq
merged 5 commits into
opensearch-project:2.3
from
rupal-bq:2.3-front-end-report-generation
Jan 3, 2023
Merged
[Backport 2.3] Use front-end report generation instead of chromium #611
rupal-bq
merged 5 commits into
opensearch-project:2.3
from
rupal-bq:2.3-front-end-report-generation
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Increment version to 2.4.1-SNAPSHOT (#540) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * --wip-- Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add initial implementation of client reporting generation Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix url with basepath Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update header footer height Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update dialog text to not close dialog Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove console.log Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove unused components Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium references Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add report generation error handling Signed-off-by: Joshua Li <joshuali925@gmail.com> * Minor refactors Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add postinstall patch to support safari for html2canvas Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add dompurify Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix build error Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium from CI Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update CI artifact name Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
…eneration Signed-off-by: Rupal Mahajan <maharup@amazon.com>
joshuali925
approved these changes
Jan 3, 2023
mengweieric
approved these changes
Jan 3, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-611-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4c4f8c3939ee134606509a38a403e432ee53f7c0
# Push it to GitHub
git push --set-upstream origin backport/backport-611-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0 Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
) * Bump version 2.3.1 (#500) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Use front-end report generation instead of chromium (#586) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Increment version to 2.4.1-SNAPSHOT (#540) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * --wip-- Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add initial implementation of client reporting generation Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix url with basepath Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update header footer height Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update dialog text to not close dialog Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove console.log Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove unused components Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium references Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add report generation error handling Signed-off-by: Joshua Li <joshuali925@gmail.com> * Minor refactors Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add postinstall patch to support safari for html2canvas Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add dompurify Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix build error Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium from CI Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update CI artifact name Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix workflow Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix dompurify version for build Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> (cherry picked from commit 4c4f8c3)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
) * Bump version 2.3.1 (#500) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Use front-end report generation instead of chromium (#586) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Increment version to 2.4.1-SNAPSHOT (#540) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * --wip-- Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add initial implementation of client reporting generation Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix url with basepath Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update header footer height Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update dialog text to not close dialog Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove console.log Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove unused components Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium references Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add report generation error handling Signed-off-by: Joshua Li <joshuali925@gmail.com> * Minor refactors Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add postinstall patch to support safari for html2canvas Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add dompurify Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix build error Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium from CI Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update CI artifact name Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix workflow Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix dompurify version for build Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> (cherry picked from commit 4c4f8c3)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-611-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4c4f8c3939ee134606509a38a403e432ee53f7c0
# Push it to GitHub
git push --set-upstream origin backport/backport-611-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2.3 remove chromium
Issues Resolved
#577
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.