Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Look&Feel] Fit and Finishes Changes for Security Analytics #1147

Merged
merged 10 commits into from
Sep 9, 2024
Merged

[Look&Feel] Fit and Finishes Changes for Security Analytics #1147

merged 10 commits into from
Sep 9, 2024

Conversation

danieldong51
Copy link
Contributor

@danieldong51 danieldong51 commented Sep 6, 2024 •
edited
Loading

Description

This PR applies the following fit and finish changes to the Security Analytics plugin:

  1. Semantic Header Sizes:
    a. H1: For page header (handled centrally) or page titles without a page header (these shouldn’t exist)
    b. H2: For headings immediately under H1s, Modal and Flyout titles, top level Panel titles
    c. H3: For headings immediately below H2s
  2. Text Sizes: Using EuiText size="s"
  3. Context Menus: Using small context menus
  4. Tabs: Using small tabs
  5. Panels: Maintaining margin sizes

Screenshots

Page Before After
Getting Started 0 Getting Started Before 0 Getting Started Post
Overview 1 Overview Before 1 Overview Post
Findings 2 Findings Before 2 Findings Post
Security Alerts 3 Security Alerts Before 3 Security Alerts Post
Threat Intelligence 4 Threat Before 4 Threat Post
Threat Intelligence: Create 5 Threat Add Before 5 Threat Add Post
Detectors: Create 7 Detectors Create Before 7 Detectors Create Post
Detectors: Rule 8 Detector Rule Create Before 8 Detector Rule Create Post
Correlation Rule: Create 9 Correlation Create Before 9 Correlation Create Post

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.85%. Comparing base (6439704) to head (8e05f32).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
- Coverage   31.76%   27.85%   -3.92%     
==========================================
  Files         162      194      +32     
  Lines        5509     7349    +1840     
  Branches     1027     1409     +382     
==========================================
+ Hits         1750     2047     +297     
- Misses       3552     5081    +1529     
- Partials      207      221      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AMoo-Miki
AMoo-Miki approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan; looks good.

Unrelated to your PR: i find it concerning that there seems to be no use of i18n in this plugin.

@amsiglan
Copy link
Collaborator

amsiglan commented Sep 7, 2024

Thanks Dan; looks good.

Unrelated to your PR: i find it concerning that there seems to be no use of i18n in this plugin.

I have it in my backlog to complete this

amsiglan
amsiglan requested changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@amsiglan amsiglan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress tests need to be updated after these changes

@danieldong51
Fit and Finish Changes
1cfd4c7 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Fit and Finish Changes
4713a41 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Fit and Finish Snapshot Tests
2977a7e 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Fit and Finish Changes
bc00ea5 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Fit and Finish Changes
68c7304 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Fit and Finish Snapshot Updates
c65fb18 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Fit and Finish Content Panel update
fcc2a49 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Fit and Finish Content Panel update
eb0ae6c 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@danieldong51
Release Notes
5299fdb 
Signed-off-by: Dan Dong <danieldong51@gmail.com>
@amsiglan
update tests
b028eb0 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
@amsiglan amsiglan merged commit cdd0f46 into opensearch-project:main Sep 9, 2024
6 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 9, 2024
@github-actions @amsiglan
[Look&Feel] Fit and Finishes Changes for Security Analytics (#1147)
93f74b9 
* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Snapshot Tests

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Snapshot Updates

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Content Panel update

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Content Panel update

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Release Notes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* update tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit cdd0f46)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 9, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 9, 2024
@github-actions @amsiglan
[Look&Feel] Fit and Finishes Changes for Security Analytics (#1147)
36565f8 
* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Snapshot Tests

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Changes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Snapshot Updates

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Content Panel update

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fit and Finish Content Panel update

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Release Notes

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* update tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit cdd0f46)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 9, 2024
Merged
amsiglan added a commit that referenced this pull request Sep 9, 2024
@opensearch-trigger-bot @github-actions @amsiglan
[Look&Feel] Fit and Finishes Changes for Security Analytics (#1147) (#…
d641e7f 
…1156)

* Fit and Finish Changes



* Fit and Finish Changes



* Fit and Finish Snapshot Tests



* Fit and Finish Changes



* Fit and Finish Changes



* Fit and Finish Snapshot Updates



* Fit and Finish Content Panel update



* Fit and Finish Content Panel update



* Release Notes



* update tests



---------




(cherry picked from commit cdd0f46)

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit that referenced this pull request Sep 10, 2024
@opensearch-trigger-bot @github-actions @amsiglan
[Look&Feel] Fit and Finishes Changes for Security Analytics (#1147) (#…
79a7ce3 
…1155)

* Fit and Finish Changes



* Fit and Finish Changes



* Fit and Finish Snapshot Tests



* Fit and Finish Changes



* Fit and Finish Changes



* Fit and Finish Snapshot Updates



* Fit and Finish Content Panel update



* Fit and Finish Content Panel update



* Release Notes



* update tests



---------




(cherry picked from commit cdd0f46)

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@riysaxen-amzn riysaxen-amzn riysaxen-amzn approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@amsiglan amsiglan amsiglan approved these changes

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danieldong51 @amsiglan @AMoo-Miki @riysaxen-amzn @AWSHurneyt