Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite Monitor Integration Tracker Meta #219

Closed
4 tasks done
eirsep opened this issue Jan 4, 2023 · 3 comments
Closed
4 tasks done

Composite Monitor Integration Tracker Meta #219

eirsep opened this issue Jan 4, 2023 · 3 comments
Assignees
@eirsep
Labels
v2.7.0

Comments

@eirsep
Copy link
Member

eirsep commented Jan 4, 2023 •
edited
Loading

@eirsep eirsep self-assigned this Jan 4, 2023
@eirsep
Copy link
Member Author

eirsep commented Jan 4, 2023 •
edited
Loading

Feature branch for Common Utils package with Composite Monitor changes: feature/composite-monitor

Build common utils jar and consume in security analytics.

Raise PR with destination branch as feature/composite-monitor in security analytics

@stevanbz
Copy link
Contributor

stevanbz commented Feb 6, 2023

I created one PR for all the tickets listed above:
#316

This PR is made against the branch - @eirsep and me agreed that we are going to use like "development" branch for composite monitors.

The main idea followed was that once the new detectors are being created, the workflow with delegate monitors will be created.

@stevanbz stevanbz mentioned this issue Feb 6, 2023
Open
5 tasks
@eirsep eirsep added the v2.7.0 label Mar 30, 2023
@eirsep eirsep assigned stevanbz and unassigned stevanbz Mar 30, 2023
@eirsep eirsep mentioned this issue Mar 30, 2023
Closed
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this issue Feb 20, 2024
@djindjic
Rule flyout opening from Findings and Alerts page (opensearch-project…
11e47b3 
…#219)

* rule flyout opening from findings and alerts page

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* update cypress test for findings page

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* make code shorter

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* toast error notifications for rule deletion

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* cleanup component state

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* avoid as any in favor of RuleItemInfoBase

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* fix cypress test for rules

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@engechas
Copy link
Collaborator

This functionality is implemented. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirsep eirsep

Labels
v2.7.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eirsep @stevanbz @engechas