Update to Safe yaml constructor #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
============================================
+ Coverage 39.06% 39.08% +0.01%
- Complexity 890 891 +1
============================================
Files 176 176
Lines 6722 6722
Branches 820 820
============================================
+ Hits 2626 2627 +1
Misses 3854 3854
+ Partials 242 241 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@dreamer-89 this is the same pr as this one https://github.com/opensearch-project/security-analytics/pull/198/files |
Thanks @sbcd90 for pointing this out. Closing in favour of #198 |
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* remove unused service Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * refactor form state Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * extract model and mappers Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * Extract Visual Rule Editor Component Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix missing default id Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml editor Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml rule editor mappings Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * more mapping guards Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * remove console.log's Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * YAML editor - cypress test Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml editor snapshot test Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * rename model Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * more validations on yaml editor Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * use eui form validation error box Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * re-generate snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* remove unused service Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * refactor form state Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * extract model and mappers Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * Extract Visual Rule Editor Component Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix missing default id Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml editor Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml rule editor mappings Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * more mapping guards Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * remove console.log's Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * YAML editor - cypress test Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml editor snapshot test Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * rename model Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * more validations on yaml editor Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * use eui form validation error box Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * re-generate snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* remove unused service Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * refactor form state Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * extract model and mappers Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * Extract Visual Rule Editor Component Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * fix missing default id Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml editor Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml rule editor mappings Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * more mapping guards Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * remove console.log's Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * YAML editor - cypress test Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * yaml editor snapshot test Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * rename model Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * more validations on yaml editor Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * use eui form validation error box Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * re-generate snapshot Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suraj Singh surajrider@gmail.com
Description
Based on security best practices, changeing default to safe yaml constructor [1].
https://bitbucket.org/snakeyaml/snakeyaml/wiki/Documentation
Issues Resolved
opensearch-project/OpenSearch#5576
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.