Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses changes related to default admin credentials #832

Merged

Conversation

DarshitChanpura
Copy link
Member

Description

There were recent changes to admin credentials using demo configuration. admin is no longer an accepted password, instead a custom password needs to be supplied. This PR address that change in the security test workflow.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@jowg-amazon jowg-amazon merged commit ea3dc80 into opensearch-project:main Feb 6, 2024
15 of 17 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit ea3dc80)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-832-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ea3dc80b9c1858c1861895796a7d6a63b2291d72
# Push it to GitHub
git push --set-upstream origin backport/backport-832-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-832-to-2.x.

sbcd90 pushed a commit that referenced this pull request Feb 6, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2.12.0] Ensure CI/documentation reflect changes to default admin credentials
3 participants