Skip to content

Commit

Permalink
Try gecko driver commit id and remove jdk in cypress
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Liang <jiallian@amazon.com>
  • Loading branch information
RyanL1997 committed Feb 1, 2023
1 parent 9da6a34 commit 0c95b14
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 13 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cypress-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ jobs:
fail-fast: false
matrix:
os: [ ubuntu-latest , windows-latest ]
jdk: [ 11, 17 ]
#jdk: [ 11, 17 ]
runs-on: ${{ matrix.os }}

steps:
- name: Set up JDK
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.jdk }}
#- name: Set up JDK
# uses: actions/setup-java@v1
# with:
# java-version: ${{ matrix.jdk }}

- name: Checkout Branch
uses: actions/checkout@v3
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
with:
java-version: ${{ matrix.jdk }}

- uses: browser-actions/setup-geckodriver@latest
- uses: browser-actions/setup-geckodriver@3570fb
- run: geckodriver --version

- name: Set up Firefox browser
Expand All @@ -38,13 +38,6 @@ jobs:
- run: firefox --version
if: ${{ runner.os == 'Linux' }}

#- name: Set up Firefox browser for Linux
# if: ${{ runner.os == 'Linux' }}
# uses: browser-actions/setup-firefox@latest
# with:
# browser: firefox
# version: latest

# Browser-action version does not work on Windows
- name: Set up Firefox browser for Windows
if: ${{ runner.os == 'Windows' }}
Expand Down

0 comments on commit 0c95b14

Please sign in to comment.