Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Permissions lists CLUSTER_PERMISSIONS/INDEX_PERMISSIONS should be retrieved at runtime from plugins #1196

Open
peternied opened this issue Nov 3, 2022 · 6 comments
Labels
enhancement New feature or request triaged

Comments

@peternied
Copy link
Member

Is your feature request related to a problem?
Developers in the OpenSearch project have to update a file outside their repository to update the list of permissions that are shown in the security plugin's permission UX.

This makes testing updates difficult and requires coordination with an external team. Since changes of this nature arrive toward the end of the release lifecycle it causes delays that can jeopardize the associated features.

What solution would you like?
It would be way easier if the list of permissions could be supplied at runtime by plugins and the security dashboard plugin could read, merge, sort, and present those values in the UX.

Do you have any additional context?
Reducing the amount of overhead to get common changes done in OpenSearch would benefit all plugins - additional plugins that aren't part of the OpenSearch distribution would have a mechanism to supply their own permissions to include in the list.

This discussion in a recent PR [1] required back and forth along with realigning expectations - and ultimately everything was already working as intended.

@peternied peternied added enhancement New feature or request untriaged labels Nov 3, 2022
@peternied
Copy link
Member Author

@ylwu-amzn What do you think of this proposal?

@ylwu-amzn
Copy link
Contributor

ylwu-amzn commented Nov 3, 2022

Please prepare a RFC with high level design and discuss with all plugin teams and community.

@peternied
Copy link
Member Author

Unfortunately I do not have bandwidth for this feature and I wanted to capture its essence before it slipped my mind. This issue will be discussed during our open triage meetings [1] if you'd like to attend

[1] https://www.meetup.com/opensearch/events/bbrkzsydcpbkb/

@peternied
Copy link
Member Author

@dagneyb This sounds like its related to registration points and other extensibility features - is there an overall effort this should be attached to?

@peternied
Copy link
Member Author

Another time when this feature would have prevented a bad user experience

@cwperks
Copy link
Member

cwperks commented Jan 5, 2024

X-Posting from this comment thread: #1725 (comment)

It is possible to get a full list of transport actions that have been registered in core (native actions + actions registered by plugins/modules), but there are a couple of problems:

  • The actions aren't necessarily categorized the same way that the security plugin categorizes the actions. i.e. This new action is a cluster permission even though it begins with indices:. At some point, I think these need to be revisited to ensure that the action naming is consistent and works with the security plugin.
  • Not all transport actions are meant to be run by users, some may be internal and only invoked by a process. I think the security plugin's ConfigUpdateAction is one example of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

3 participants