Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indices:data/read/search/template/render to cluster permissions dropdown #1725

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jan 5, 2024

Description

Adds the cluster permission to render a search template in the cluster permissions dropdown.

Render search template was made into a separate transport action in core in this PR

Category

Maintenance

Issues Resolved

Related: opensearch-project/security#3672

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ropdown

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks added the backport 2.x backport to 2.x branch label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cad47c) 67.09% compared to head (c12ed2f) 67.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1725   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          94       94           
  Lines        2404     2404           
  Branches      318      318           
=======================================
  Hits         1613     1613           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DarshitChanpura DarshitChanpura merged commit 780b3aa into opensearch-project:main Jan 11, 2024
12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2024
…ropdown (#1725)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 780b3aa)
DarshitChanpura added a commit that referenced this pull request Jan 18, 2024
…ropdown (#1725) (#1732)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 780b3aa)

Co-authored-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants