Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of deprecated TransportClient #1578

Closed
davidlago opened this issue Jan 19, 2022 · 0 comments
Closed

Replace uses of deprecated TransportClient #1578

davidlago opened this issue Jan 19, 2022 · 0 comments
Assignees
Labels

Comments

@davidlago
Copy link

davidlago commented Jan 19, 2022

Describe the bug
After the deprecated TransportClient was removed in 2.0, we need to go through the uses in this repo and update the to use a REST client instead.

Current behavior
Building the security plugin against OpenSearch 2.0 gives the following error:

Error:  /home/runner/work/security/security/src/main/java/org/opensearch/security/tools/SecurityAdmin.java:[92,39] cannot find symbol
Error:    symbol:   class TransportClient
Error:    location: package org.opensearch.client.transport

Acceptance criteria
Security plugin builds against OpenSearch 2.0 with no errors, test pass.

@DarshitChanpura DarshitChanpura self-assigned this Feb 16, 2022
jochenkressin added a commit to jochenkressin/security that referenced this issue Mar 23, 2022
…1578)

Signed-off-by: Jochen Kressin <jkressin@floragunn.com>
jochenkressin added a commit to jochenkressin/security that referenced this issue Mar 23, 2022
Signed-off-by: Jochen Kressin <jkressin@floragunn.com>
peternied pushed a commit to peternied/security that referenced this issue Apr 7, 2022
…1578)

Signed-off-by: Jochen Kressin <jkressin@floragunn.com>
peternied pushed a commit to peternied/security that referenced this issue Apr 7, 2022
Signed-off-by: Jochen Kressin <jkressin@floragunn.com>
jochenkressin added a commit to jochenkressin/security that referenced this issue Apr 10, 2022
)

While we do not need any transport client auth/auth code anymore,
we still need to check the privileges of an injected user on
transport layer. This functionality was removed by mistake and
is reenabled by this commit.

Signed-off-by: Jochen Kressin <jkressin@floragunn.com>
davidlago pushed a commit that referenced this issue Apr 12, 2022
* Remove code related to TransportClient auth/auth (#1578)

Signed-off-by: Jochen Kressin <jkressin@floragunn.com>
wuychn pushed a commit to ochprince/security that referenced this issue Mar 16, 2023
* Remove code related to TransportClient auth/auth (opensearch-project#1578)

Signed-off-by: Jochen Kressin <jkressin@floragunn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants