Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthentic…

[debjanibnrj]

…ator"

This reverts commit 59d12de.

opendistro-for-elasticsearch/security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
   Bug fix

2. Github Issue # or road-map entry, if available:

3. Description of changes:
   We made a change to default JWT subject_key to SAML subject_key if SAML subject_key is present.

However JWT keys have specific values and cannot always take up SAML key values. This is why we are reverting this fix.

4. Why these changes are required?

5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
   Tested on local environment.

7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

8. Is it backport from master branch? (If yes, please add backport PR # and commits #)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

Merging #1012 (ebe80c8) into opendistro-1.11 (429afde) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@                  Coverage Diff                  @@
##             opendistro-1.11    #1012      +/-   ##
=====================================================
- Coverage              64.00%   63.95%   -0.06%     
  Complexity              3169     3169              
=====================================================
  Files                    239      239              
  Lines                  16896    16896              
  Branches                3036     3036              
=====================================================
- Hits                   10814    10805       -9     
- Misses                  4532     4543      +11     
+ Partials                1550     1548       -2     

Impacted Files	Coverage Δ	Complexity Δ
...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java	70.00% <66.66%> (ø)	24.00 <0.00> (ø)
...relasticsearch/security/rest/TenantInfoAction.java	77.61% <0.00%> (-10.45%)	15.00% <0.00%> (ø%)
...relasticsearch/security/auditlog/NullAuditLog.java	33.33% <0.00%> (-4.77%)	7.00% <0.00%> (-1.00%)
...ty/configuration/ConfigurationLoaderSecurity7.java	67.76% <0.00%> (-0.83%)	10.00% <0.00%> (ø%)
...ecurity/ssl/DefaultOpenDistroSecurityKeyStore.java	65.66% <0.00%> (-0.24%)	67.00% <0.00%> (-1.00%)
...iance/ComplianceIndexingOperationListenerImpl.java	62.31% <0.00%> (+1.44%)	23.00% <0.00%> (+1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429afde...2d28c16. Read the comment docs.