Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthentic… #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator" This reverts commit b487ed0.
(cherry picked from commit 7db5afe)
dinusX
approved these changes
Feb 5, 2021
cliu123
approved these changes
Feb 5, 2021
Codecov Report
@@ Coverage Diff @@
## opendistro-1.4 #1015 +/- ##
====================================================
- Coverage 63.56% 63.48% -0.09%
+ Complexity 3028 3023 -5
====================================================
Files 235 235
Lines 16704 16704
Branches 3013 3013
====================================================
- Hits 10618 10604 -14
- Misses 4538 4551 +13
- Partials 1548 1549 +1
Continue to review full report at Codecov.
|
hardik-k-shah
approved these changes
Feb 5, 2021
gaobinlong
pushed a commit
to gaobinlong/security
that referenced
this pull request
Aug 30, 2023
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ator"
This reverts commit 59d12de.
opendistro-for-elasticsearch/security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Bug fix
Github Issue # or road-map entry, if available:
Description of changes:
We made a change to default JWT subject_key to SAML subject_key if SAML subject_key is present.
However JWT keys have specific values and cannot always take up SAML key values. This is why we are reverting this fix.
Why these changes are required?
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
Tested on local environment.
TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
Is it backport from master branch? (If yes, please add backport PR # and commits #)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.