Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CODEOWNERS file (opensearch-project#1193) #1283

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Jun 21, 2021

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  4. Why these changes are required?

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@vrozov vrozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing cherry pick message

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021

Codecov Report

Merging #1283 (76fdeee) into opendistro-1.9 (81d7956) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             opendistro-1.9    #1283      +/-   ##
====================================================
- Coverage             64.00%   63.93%   -0.07%     
+ Complexity             3160     3158       -2     
====================================================
  Files                   239      239              
  Lines                 16889    16889              
  Branches               3033     3033              
====================================================
- Hits                  10809    10798      -11     
- Misses                 4528     4540      +12     
+ Partials               1552     1551       -1     
Impacted Files Coverage Δ
...ecurity/configuration/StaticResourceException.java 0.00% <0.00%> (-25.00%) ⬇️
...ch/security/auditlog/routing/AsyncStoragePool.java 50.00% <0.00%> (-8.34%) ⬇️
...csearch/security/dlic/rest/api/AuditApiAction.java 63.82% <0.00%> (-4.26%) ⬇️
...asticsearch/security/support/ReflectionHelper.java 47.58% <0.00%> (-2.07%) ⬇️
...earch/security/auditlog/impl/AbstractAuditLog.java 73.92% <0.00%> (-1.08%) ⬇️
...search/security/tools/OpenDistroSecurityAdmin.java 47.52% <0.00%> (+0.26%) ⬆️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.25% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d7956...76fdeee. Read the comment docs.

@vrozov vrozov merged commit 8fdba4f into opensearch-project:opendistro-1.9 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants