add non-null to store non-default values when patching security config

[nsri19]

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
   Bug fix

2. Github Issue # or road-map entry, if available:
   [BUG] Patching security config flips some config settings from false to true. #1435

3. Description of changes:

• Added JsonInclude.Include.NON_NULL to ConfigV6 and ConfigV7 properties to store all non-null & non-default values
• Added unit test
• Modified ConfigV6Test and ConfigV7Test as bug causing multitenancy_enabled to revert to default values is fixed

4. Why these changes are required?
   Currently, security config settings that default to true are flipped from false to default (true) on patch requests. This fix removes this bug.
   The similar fixes have been applied to audit/config: Add non-null to store even non-default values in serialization #652

5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1444 (b9a494b) into main (69a2b6e) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1444      +/-   ##
============================================
- Coverage     64.86%   64.65%   -0.21%     
+ Complexity     3228     3223       -5     
============================================
  Files           247      247              
  Lines         17335    17335              
  Branches       3072     3072              
============================================
- Hits          11244    11208      -36     
- Misses         4535     4577      +42     
+ Partials       1556     1550       -6     

Impacted Files	Coverage Δ
...search/security/securityconf/impl/v6/ConfigV6.java	64.44% <100.00%> (ø)
...search/security/securityconf/impl/v7/ConfigV7.java	73.93% <100.00%> (+0.60%)	⬆️
...zon/dlic/auth/http/kerberos/util/KrbConstants.java	0.00% <0.00%> (-88.89%)	⬇️
...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java	0.00% <0.00%> (-14.22%)	⬇️
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java	57.57% <0.00%> (-0.76%)	⬇️
.../org/opensearch/security/auth/BackendRegistry.java	58.85% <0.00%> (-0.53%)	⬇️
...ch/security/securityconf/DynamicConfigModelV7.java	63.69% <0.00%> (ø)
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java	57.25% <0.00%> (+0.76%)	⬆️
...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java	84.90% <0.00%> (+2.83%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a2b6e...b9a494b. Read the comment docs.

[cliu123]

Please add an empty line at EOF.

[nsri19]

done, thank you!

[cliu123]

How are the changes applied to ConfigV6 tested?

[nsri19]

Not able to test changes applied to ConfigV6. Keeping the changes to maintain consistency with ConfigV7.

[hardik-k-shah]

please create 6x domain to test those changes.

[hardik-k-shah]

As discussed, this is mainly for 6.x to 7.x migration and will not impact 6.x directly. But lets test migration case as discussed offline.

[vrozov]

Is security config the only impacted object? Can the same apply to other patchable objects? If other objects are also impacted, should they be also changed? Or it may be better to change ObjectMapper behavior globally? Another option to consider is to apply annotation only to properties impacted (reverted) by patch.

[hardik-k-shah]

testSecurityConfigForHTTPPatch()

[hardik-k-shah]

We should use HTTP PATCH method request instead patching to avoid confusion with software patching procedure.