Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netty-tcnative dependency to unblock security plugin build on ARM64 #1649

Merged

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Feb 28, 2022

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
  • Why these changes are required? netty-tcnative-2.0.25.Final does not support ARM64.
  • What is the old behavior before changes and new behavior after changes? No behavior changes

Issues Resolved

#1647

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Compile and UTs

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123 cliu123 requested a review from a team February 28, 2022 21:06
…ARM64

Signed-off-by: cliu123 <lc12251109@gmail.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what were these dependencies doing before?

@cliu123
Copy link
Member Author

cliu123 commented Feb 28, 2022

Do you know what were these dependencies doing before?

Good question! It was introduced to support OpenSSL that has been discontinued for a while.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #1649 (4142bc2) into main (d3c10b3) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1649      +/-   ##
============================================
- Coverage     64.59%   64.53%   -0.06%     
+ Complexity     3214     3213       -1     
============================================
  Files           247      247              
  Lines         17352    17351       -1     
  Branches       3082     3073       -9     
============================================
- Hits          11208    11198      -10     
- Misses         4594     4596       +2     
- Partials       1550     1557       +7     
Impacted Files Coverage Δ
...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java 39.13% <0.00%> (-4.35%) ⬇️
.../org/opensearch/security/support/ConfigHelper.java 80.39% <0.00%> (-1.97%) ⬇️
...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java 49.18% <0.00%> (-1.64%) ⬇️
.../org/opensearch/security/auth/BackendRegistry.java 58.85% <0.00%> (-0.53%) ⬇️
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 57.57% <0.00%> (-0.38%) ⬇️
...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java 28.35% <0.00%> (-0.38%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 47.39% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c10b3...4142bc2. Read the comment docs.

@peternied peternied merged commit d32d7f6 into opensearch-project:main Feb 28, 2022
@cliu123 cliu123 deleted the remove_netty_tcnative_dependency branch February 28, 2022 22:58
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.3.0][BUG] ARM64 build failed due to could not find netty-tcnative-2.0.25.Final-linux-aarch_64.jar
4 participants