-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove netty-tcnative dependency to unblock security plugin build on ARM64 #1649
Remove netty-tcnative dependency to unblock security plugin build on ARM64 #1649
Conversation
…ARM64 Signed-off-by: cliu123 <lc12251109@gmail.com>
e801616
to
4142bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what were these dependencies doing before?
Good question! It was introduced to support OpenSSL that has been discontinued for a while. |
Codecov Report
@@ Coverage Diff @@
## main #1649 +/- ##
============================================
- Coverage 64.59% 64.53% -0.06%
+ Complexity 3214 3213 -1
============================================
Files 247 247
Lines 17352 17351 -1
Branches 3082 3073 -9
============================================
- Hits 11208 11198 -10
- Misses 4594 4596 +2
- Partials 1550 1557 +7
Continue to review full report at Codecov.
|
…ARM64 (opensearch-project#1649) Signed-off-by: cliu123 <lc12251109@gmail.com>
Description
[Describe what this change achieves]
netty-tcnative-2.0.25.Final
does not support ARM64.Issues Resolved
#1647
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Compile and UTs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.