Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowlist.yml to where it is not being handled in securityadmin tool. #2046

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Aug 23, 2022

Signed-off-by: cliu123 lc12251109@gmail.com

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Bug fix

Issues Resolved

#2047

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 requested a review from a team August 23, 2022 21:10
@cliu123 cliu123 changed the title security admin does not handle allowlist.yml in all the places where it handles whitelist.yml Add allowlist.yml to 3 places in securityadmin tool Aug 23, 2022
@cliu123 cliu123 changed the title Add allowlist.yml to 3 places in securityadmin tool Add allowlist.yml to where it is not being handled in securityadmin tool. Aug 23, 2022
@cliu123 cliu123 merged commit 287e945 into opensearch-project:main Aug 23, 2022
@cliu123 cliu123 deleted the add_whitelist_yml_file_to_securityadmin_tool branch August 23, 2022 21:48
@cliu123 cliu123 added the backport 2.x backport to 2.x branch label Aug 23, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2022
Signed-off-by: cliu123 <lc12251109@gmail.com>
(cherry picked from commit 287e945)
cliu123 added a commit that referenced this pull request Aug 24, 2022
Signed-off-by: cliu123 <lc12251109@gmail.com>
(cherry picked from commit 287e945)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
…ct#2046)

Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…ct#2046) (opensearch-project#2048)

Signed-off-by: cliu123 <lc12251109@gmail.com>
(cherry picked from commit 287e945)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants