Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version 2.5.0 #2249

Merged

Conversation

DarshitChanpura
Copy link
Member

Description

Bumps version to 2.5.0-SNAPSHOT

Created manually as auto-cut PR: #2210 doesn't contain all changes.

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-ci-bot and others added 2 commits November 5, 2022 00:14
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura requested a review from a team November 9, 2022 16:08
@cwperks
Copy link
Member

cwperks commented Nov 9, 2022

@DarshitChanpura Any ETA on the availability of org.opensearch.gradle:build-tools:2.5.0-SNAPSHOT?

@DarshitChanpura
Copy link
Member Author

None yet.. Engineering effectiveness team is working on adding a 2.5.0 manifest. Once that is available, 2.5.0 build will be kicked-off

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #2249 (cc31b3f) into 2.x (58a9f6d) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #2249      +/-   ##
============================================
+ Coverage     61.05%   61.19%   +0.13%     
- Complexity     3249     3254       +5     
============================================
  Files           258      258              
  Lines         18125    18125              
  Branches       3231     3231              
============================================
+ Hits          11067    11092      +25     
+ Misses         5487     5461      -26     
- Partials       1571     1572       +1     
Impacted Files Coverage Δ
.../dlic/auth/http/jwt/keybyoidc/KeySetRetriever.java 79.26% <0.00%> (+2.43%) ⬆️
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 59.30% <0.00%> (+3.48%) ⬆️
...nsearch/security/dlic/rest/api/AuditApiAction.java 68.08% <0.00%> (+4.25%) ⬆️
.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java 68.30% <0.00%> (+8.45%) ⬆️
...ecurity/configuration/StaticResourceException.java 25.00% <0.00%> (+25.00%) ⬆️
...t/keybyoidc/AuthenticatorUnavailableException.java 40.00% <0.00%> (+40.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

peternied
peternied previously approved these changes Nov 17, 2022
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when you've got it passing CI

@DarshitChanpura DarshitChanpura merged commit 76b07e7 into opensearch-project:2.x Nov 17, 2022
@cwperks
Copy link
Member

cwperks commented Nov 22, 2022

@DarshitChanpura When should security be added to the 2.5.0 build manifest? The security-dashboards-plugin cannot be version incremented without security being in the manifest and having SNAPSHOT artifacts for 2.5.0.

@DarshitChanpura
Copy link
Member Author

@DarshitChanpura When should security be added to the 2.5.0 build manifest? The security-dashboards-plugin cannot be version incremented without security being in the manifest and having SNAPSHOT artifacts for 2.5.0.

Hmm.. I was under the impression they automatically added it for all back-end plugins. Nevertheless, I have created opensearch-project/opensearch-build#2931 to add it to 2.5.0 manifest

@DarshitChanpura DarshitChanpura mentioned this pull request Nov 22, 2022
23 tasks
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
* Increment version to 2.5.0-SNAPSHOT

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants