Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] Increment version to 2.4.1-SNAPSHOT #2267

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

  • Incremented version to 2.4.1-SNAPSHOT.

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team November 18, 2022 00:14
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #2267 (22b42eb) into 2.4 (bca4612) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.4    #2267      +/-   ##
============================================
+ Coverage     61.09%   61.10%   +0.01%     
- Complexity     3252     3253       +1     
============================================
  Files           258      258              
  Lines         18125    18125              
  Branches       3231     3231              
============================================
+ Hits          11073    11076       +3     
+ Misses         5483     5478       -5     
- Partials       1569     1571       +2     
Impacted Files Coverage Δ
...security/auditlog/sink/ExternalOpenSearchSink.java 59.25% <0.00%> (-2.47%) ⬇️
...iance/ComplianceIndexingOperationListenerImpl.java 63.23% <0.00%> (+1.47%) ⬆️
...nsearch/security/dlic/rest/api/AuditApiAction.java 68.08% <0.00%> (+4.25%) ⬆️
...ecurity/configuration/StaticResourceException.java 25.00% <0.00%> (+25.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied
Copy link
Member

@DarshitChanpura Could you help get this PR merged?

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
peternied
peternied previously approved these changes Nov 29, 2022
mkdir bwc-test/src/test/resources/2.3.0.0
wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.3.0/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-security-2.3.0.0.zip
mv opensearch-security-2.3.0.0.zip bwc-test/src/test/resources/2.3.0.0/
mkdir bwc-test/src/test/resources/2.4.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain the immediately preceding minor version. If the goal is to test BWC from 2.4.0.0 -> 2.4.1.0 then it can be set as 2.4.0.0

Copy link
Member

@DarshitChanpura DarshitChanpura Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. My understanding is to set it to previous minor.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
@cwperks cwperks merged commit 8031157 into 2.4 Nov 29, 2022
@cwperks cwperks deleted the create-pull-request/2.4.1-SNAPSHOT branch November 29, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants