Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add jackson-annotations and jackson-databind #2391

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jan 10, 2023

Signed-off-by: Craig Perkins cwperx@amazon.com

Description

Reverts #2325 and adds jackson-annotations and jackson-databind back as direct dependencies.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Issues Resolved

opensearch-project/OpenSearch#5504

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team January 10, 2023 18:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #2391 (ecfe85d) into main (8ccad5c) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2391      +/-   ##
============================================
- Coverage     61.10%   61.05%   -0.05%     
+ Complexity     3273     3268       -5     
============================================
  Files           260      260              
  Lines         18364    18362       -2     
  Branches       3250     3249       -1     
============================================
- Hits          11221    11211      -10     
- Misses         5558     5562       +4     
- Partials       1585     1589       +4     
Impacted Files Coverage Δ
.../action/configupdate/ConfigUpdateNodeResponse.java 77.27% <0.00%> (-4.55%) ⬇️
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 54.76% <0.00%> (-1.06%) ⬇️
...search/security/transport/SecurityInterceptor.java 75.38% <0.00%> (-0.77%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 36.84% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RyanL1997 RyanL1997 added backport 2.x backport to 2.x branch backport 2.5 backport to 2.5 branch labels Jan 10, 2023
@RyanL1997 RyanL1997 merged commit 3ea4702 into opensearch-project:main Jan 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 3ea4702)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 3ea4702)
cwperks added a commit that referenced this pull request Jan 11, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 3ea4702)

Co-authored-by: Craig Perkins <cwperx@amazon.com>
RyanL1997 pushed a commit that referenced this pull request Jan 11, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 3ea4702)
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
) (opensearch-project#2392)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 3ea4702)

Co-authored-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch backport 2.5 backport to 2.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants