Add username into threadContext header #2436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
peternied
requested changes
Feb 14, 2023
There was a problem hiding this comment.
The issue associated with this pull request was closed, pushing more information into the thread context headers is an anti-pattern.
The work that is being done to pull Identity information into OpenSearch will be a recommended way to support this workflow. See https://github.com/orgs/opensearch-project/projects/89?pane=info for approximant timelines
|
Thanks for looking into this. For now, security info is not aware by OpenSearch core and no better way to get user information. By pulling identity information into core that will make it more easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hailong Cui ihailong@amazon.com
Description
[Describe what this change achieves]
Issues Resolved
#2432
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.