-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix kafka CVE-2023-25194, update kafka client to 3.4.0 #2484
Conversation
Signed-off-by: Shujian Xie <xiesj@live.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2484 +/- ##
============================================
- Coverage 61.19% 61.19% -0.01%
+ Complexity 3325 3324 -1
============================================
Files 260 260
Lines 18494 18494
Branches 3268 3268
============================================
- Hits 11318 11317 -1
Misses 5578 5578
- Partials 1598 1599 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Backwards Compatibility failure for Windows CI is unrelated to changes in this PR. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2484-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7547d035ff11a00257f6c7e8316499e2138790e8
# Push it to GitHub
git push --set-upstream origin backport/backport-2484-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2484-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7547d035ff11a00257f6c7e8316499e2138790e8
# Push it to GitHub
git push --set-upstream origin backport/backport-2484-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2484-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7547d035ff11a00257f6c7e8316499e2138790e8
# Push it to GitHub
git push --set-upstream origin backport/backport-2484-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-2484-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7547d035ff11a00257f6c7e8316499e2138790e8
# Push it to GitHub
git push --set-upstream origin backport/backport-2484-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6 Then, create a pull request where the |
@scrawfor99 FYI - these changes will not clearly backport to the 1.X/1.3 branches. They will need to manually be converted since the build script were rewrittne |
…oject#2484) Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03)
…oject#2484) Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03)
…oject#2484) Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03)
…oject#2484) Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03)
…oject#2484) Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03)
Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03) Co-authored-by: xieshujian <xiesj@live.com>
Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03) Co-authored-by: xieshujian <xiesj@live.com>
Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03) Co-authored-by: xieshujian <xiesj@live.com>
Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 7547d03) Co-authored-by: xieshujian <xiesj@live.com>
…oject#2484) Signed-off-by: Shujian Xie <xiesj@live.com> Signed-off-by: Peter Nied <peternied@hotmail.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.