Changes in role.yml for long-running operation notification feature in Index-Management repo #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
zhichao-aws
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2789 +/- ##
=========================================
Coverage 61.48% 61.49%
+ Complexity 3402 3401 -1
=========================================
Files 266 266
Lines 18865 18865
Branches 3302 3302
=========================================
+ Hits 11600 11601 +1
+ Misses 5669 5668 -1
Partials 1596 1596 |
DarshitChanpura
approved these changes
May 25, 2023
cwperks
approved these changes
May 25, 2023
RyanL1997
approved these changes
May 25, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit a580dfc)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit a580dfc)
RyanL1997
added a commit
to RyanL1997/security
that referenced
this pull request
May 26, 2023
Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997
pushed a commit
that referenced
this pull request
May 26, 2023
RyanL1997
pushed a commit
that referenced
this pull request
May 29, 2023
cwperks
pushed a commit
that referenced
this pull request
May 30, 2023
* role.yml changes for lron feature (#2789) (#2792) Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit a580dfc) Co-authored-by: zhichao-aws <zhichaog@amazon.com> * add ml model group system index (#2790) (#2797) Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 1bb2ef1) Co-authored-by: Yaliang Wu <ylwu@amazon.com> * Rest admin permissions (#2411) Permissions for REST admin user Added granular permissions for all REST API actions in OpenSearch to be individually assigned. Permissions are: - 'restapi:admin/actiongroups' - allow full access to actiongroups - 'restapi:admin/allowlist' - allow full access to allowlist - 'restapi:admin/internalusers'- allow full access to internalusers - 'restapi:admin/nodesdn'- allow full access to nodesdn - 'restapi:admin/roles' - allow full access to roles - 'restapi:admin/rolesmapping' - allow full access to roles mappings - 'restapi:admin/ssl/certs/info' - allow full access to certs info - 'restapi:admin/ssl/certs/reload' - allow full access to certs reload - 'restapi:admin/tenants' - allow full access to tenants Adds tests for these permissions. Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit d676716) * Fixes CI errors Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes HTTP5 imports Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes password related changes in tests Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Update ActionGroupsApiTest.java Remove unused import * Incorporates jar hell fix Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com> Co-authored-by: Andrey Pleskach <ples@aiven.io> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Jun 9, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Jun 13, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
3 tasks
3 tasks
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 2.8, index-management will have a new feature of sending notifications for long-running index operations(opensearch-project/OpenSearch#5479). And to build this feature, index-management plugin introduce 3 new backend API(opensearch-project/index-management#700). We want to add cluster permissions of these APIs to existing
index_management_full_accessrole. It will also include list notification channels cluster permission.Issues Resolved
opensearch-project/OpenSearch#5479
opensearch-project/index-management#700
opensearch-project/index-management#703
opensearch-project/index-management-dashboards-plugin#618
opensearch-project/documentation-website#4170
Is this a backport? If so, please add backport PR # and/or commits #
It should be backport to 2.x and released in 2.8.
Testing
The new feature has testing in index-management repo.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.