Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage label guidelines #3048

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

peternied
Copy link
Member

Description

Documents what different labels are used during triage and what they mean.

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

Signed-off-by: Peter Nied <petern@amazon.com>
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #3048 (73c8cc7) into main (59e2657) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3048      +/-   ##
============================================
- Coverage     62.41%   62.11%   -0.30%     
+ Complexity     3379     3367      -12     
============================================
  Files           267      267              
  Lines         19774    19774              
  Branches       3355     3355              
============================================
- Hits          12342    12283      -59     
- Misses         5794     5853      +59     
  Partials       1638     1638              

see 11 files with indirect coverage changes

@reta
Copy link
Collaborator

reta commented Jul 25, 2023

Looks pretty clear (to me), thanks @peternied !

Copy link

@davidlago davidlago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peternied! I think that as we define a bit more what "ready" looks like, we can add a bit more details to what it takes to add the triaged label.

@peternied peternied merged commit 93ee2ba into opensearch-project:main Jul 25, 2023
53 of 55 checks passed
@peternied peternied deleted the label-details branch July 25, 2023 17:37
@peternied
Copy link
Member Author

Thanks for the reviews, I've also updated the label descriptions on GitHub to reflect these updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify intent of untriaged and triaged labels
3 participants