-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build Break] React to changes in ActionListener and ActionResponse from #9082 #3153
[Build Break] React to changes in ActionListener and ActionResponse from #9082 #3153
Conversation
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3153 +/- ##
============================================
- Coverage 62.48% 62.43% -0.06%
+ Complexity 3357 3351 -6
============================================
Files 254 254
Lines 19749 19749
Branches 3334 3334
============================================
- Hits 12340 12330 -10
- Misses 5779 5789 +10
Partials 1630 1630
|
Manually removed gradle cache |
@cwperks With the speed snapshots are changing do we need to disable caching on OpenSearch to prevent this manual step? |
Yes, please. I once had to delete ~80 caches manually. I did that because there was an approved PR and instead of opening a new one I went through the manual process of deleting caches. There is no bulk operation, it must be done one-by-one >.< |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3153-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 31ec3220841d063042926936bd803afaf2ace637
# Push it to GitHub
git push --set-upstream origin backport/backport-3153-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
…nsearch-project#3153) Reacts to changes in ActionListener and ActionResponse introduced in opensearch-project/OpenSearch#9082 Also includes a fix for a call to XContentHelper.toXContent in response to opensearch-project/OpenSearch#9156 Signed-off-by: Craig Perkins <craig5008@gmail.com> (cherry picked from commit 31ec322)
### Description Manual backport for #3153 of React to changes in ActionListener in core Also includes a fix for a call to XContentHelper.toXContent in response to opensearch-project/OpenSearch#9156 ### Issues Resolved * Relate opensearch-project/OpenSearch#9352 * Relate #3153 ### Check List - [ ] ~New functionality includes testing~ - [ ] ~New functionality has been documented~ - [X] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com>
Description
Reacts to changes in ActionListener and ActionResponse introduced in opensearch-project/OpenSearch#9082
Also includes a fix for a call to XContentHelper.toXContent in response to opensearch-project/OpenSearch#9156
Maintenance
Issues Resolved
#3151
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.