Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add [2.x] to dependabot commit message #3219

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 21, 2023

Description

Prefixes the dependabot commit message with [2.x] for PRs against the 2.x branch.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #3219 (94d0947) into 2.x (478b27d) will decrease coverage by 2.38%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #3219      +/-   ##
============================================
- Coverage     62.21%   59.83%   -2.38%     
+ Complexity     3313     3199     -114     
============================================
  Files           265      265              
  Lines         19508    19508              
  Branches       3329     3329              
============================================
- Hits          12137    11673     -464     
- Misses         5744     6221     +477     
+ Partials       1627     1614      -13     

see 23 files with indirect coverage changes

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented Aug 21, 2023

Bwc test failure is due to compilation error on 2.x.

The compilation error is due to a bad import in CredentialsValidator which was removed on main in this PR that was not backported to 2.x yet.

Build started failing on 2.x an hour ago after the merge of this PR: opensearch-project/OpenSearch#9367

@cwperks cwperks merged commit 31100ab into opensearch-project:2.x Aug 21, 2023
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants