[Backport 2.x] Clean up REST API (Part 1) (#2900) #3223
Merged
+1,405
−1,308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
willyborankin
force-pushed
the
backport-2900-to-2.x
branch
from
576c81a
to
98549cf
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #3223 +/- ##
============================================
+ Coverage 62.21% 62.29% +0.07%
+ Complexity 3313 3291 -22
============================================
Files 265 252 -13
Lines 19508 19469 -39
Branches 3329 3308 -21
============================================
- Hits 12137 12128 -9
+ Misses 5744 5718 -26
+ Partials 1627 1623 -4
|
willyborankin
force-pushed
the
backport-2900-to-2.x
branch
2 times, most recently
from
538a26c
to
cfcd00f
Compare
The aim of this PR is to start cleaning code in REST API since with the current implementation is difficult to understand and support. Changes: - Implemented new `RequestConetnValidator` class which uses the same validation logic as `AbstractConfigurationValidator` - Removed all redundant `AbstractConfigurationValidator` extensions Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit 6bac470) Signed-off-by: Andrey Pleskach <ples@aiven.io> Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin
force-pushed
the
backport-2900-to-2.x
branch
from
cfcd00f
to
36fc3c7
Compare
peternied
approved these changes
Aug 21, 2023
cwperks
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport 6bac470 from #2900